Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific cooldown for each bot account #106

Open
Ecstasyyy1337 opened this issue Jul 8, 2021 · 3 comments
Open

Add specific cooldown for each bot account #106

Ecstasyyy1337 opened this issue Jul 8, 2021 · 3 comments
Labels
Enhancement New feature or change request

Comments

@Ecstasyyy1337
Copy link

Ecstasyyy1337 commented Jul 8, 2021

If I start more sessions with randomizeAccounts true or just false but I start when same sessions are at bot 0/1/2/3 ( very small delay between them) the accounts get cooldowns that result fails so it would be a fix to add a cooldown on each account after comment sent / failed so that account cannot be used again until that /account cooldown isnt done.
Edit: if the 1st session is started and bot 1 commented, the 2nd session its started same time with bot 1 so bot 1 have a cooldown so set session 2 advancedconfig.json account delay is setted to 10 seconds for example, the 2nd session is paused for advancedconfig.json session cooldown 30 seconds for example and after that 30 seconds session will start again.

@Ecstasyyy1337 Ecstasyyy1337 added the Enhancement New feature or change request label Jul 8, 2021
@3urobeat
Copy link
Owner

Idea: Could also be done with a queue. globalcommentcooldown will need to be reworked anyway to allow being applied to certain accounts and not the whole bot.

@3urobeat
Copy link
Owner

3urobeat commented Jun 4, 2022

Soo I'm finally addressing this, sorry for the long wait.

What I think I'm going to do:

  • give each bot account a cooldown/timestamp of the last comment
  • store that in a database to persist through restarts
  • prioritize accounts in the next comment request that haven't commented for the longest time

I'm not 100% sure yet how this is affected by randomizeAccounts but since the comment loop checks if the first account commented as the last one in the previous iteration when re-shuffling this should be fine...

This should be the best solution I think

@3urobeat
Copy link
Owner

3urobeat commented Jun 4, 2022

On second thought I don't think it is going to help much and will just make everything more complicated.
Accounts can't be used in multiple sessions at the same time and they all get a cooldown so the next time they are used they won't fail instantly.
The same account also can't comment two times back to back with randomizeAccounts set to true because of the check I explained above.

So what I still might be doing is to make a database where each bot account gets a cooldown directly after commenting for three reasons:

  • cooldowns will persist through restarts
  • the accounts doing the first few comments might be available again sooner
  • checking might be easier and cleaner?

However this means we have to rethink how the botaccountcooldown is used as it will make the running session wait for each account to become available again when re-shuffling.
This looks like a medium big problem to solve elegantly.
Edit: Or I just ignore cooldowns during the same session. This would make the bot work the same as it is currently but still give the few benefits from above.

Is this really worth it? Seems like a lot of work for not so much benefits.
I'm not sure, I have to rethink this

@3urobeat 3urobeat changed the title account cooldown & randomizeAccounts fix (proxies) Add specific cooldown for each bot account Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or change request
Projects
None yet
Development

No branches or pull requests

2 participants