Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying amount in !joingroup command #249

Open
pushkinb opened this issue Jun 8, 2024 · 5 comments
Open

Add support for specifying amount in !joingroup command #249

pushkinb opened this issue Jun 8, 2024 · 5 comments
Labels
Enhancement New feature or change request

Comments

@pushkinb
Copy link

pushkinb commented Jun 8, 2024

Please describe the bug
What happened?

Hello, i have a problems when i use command !joingroup, when i use the command with parametrs "!joingroups 100" script send me "Joining group '103582791473802010' with all bot accounts..." but he did not take into account that I specified the number of accounts I needed, and began to join the group all at once

Full error stack trace
If you've got an error, please post the entire error stack trace here!
image

Additional context
Please add any other information here, if you have some.

@pushkinb pushkinb added the Bug Something isn't working and the problem is in the code label Jun 8, 2024
@3urobeat
Copy link
Owner

3urobeat commented Jun 8, 2024

Hi, thanks for opening an issue!

The !joingroup command does not support specifying an amount (as of now).
You can see this in the commands documentation.

It would probably be a good idea to use a standardized format for all commands to reduce confusion.
I think I'll consider changing all relevant commands to use the same !cmd amount destination format in v2.16.0.

Changing tag to enhancement. I'll leave the issue open and update if I have news to share.

@3urobeat 3urobeat added Enhancement New feature or change request and removed Bug Something isn't working and the problem is in the code labels Jun 8, 2024
@3urobeat 3urobeat changed the title problems when i use command !joingroup Add support for specifying amount in !joingroup command Jun 8, 2024
@pushkinb
Copy link
Author

pushkinb commented Jun 8, 2024

this problems i find also in command "addfriend":
image

@3urobeat
Copy link
Owner

3urobeat commented Jun 8, 2024

Yep, both commands use all accounts and do not take an amount argument.
It is documented in the Commands documentation.

@pushkinb
Copy link
Author

oh, can i make take amount argument for this commands please?

@3urobeat
Copy link
Owner

3urobeat commented Jan 5, 2025

The commands !joingroup & !addfriend now take a amount parameter before the ID parameter, just like all other request commands.
You can also provide the keyword "max" or "all" as the amount parameter to use all available accounts, just like the default behavior before.
If the bot replies with "Joining ... with 0 bot accounts..." then obviously no accounts were eligible to join the group (= are already member of the group).

I'll leave this issue open until Version 2.16.0 is out on the master branch which implements these new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or change request
Development

No branches or pull requests

2 participants