Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'markersAreaEnabled' / 'minConfidence' parameter is undefined. #106

Closed
dirkk0 opened this issue Nov 19, 2020 · 8 comments
Closed

'markersAreaEnabled' / 'minConfidence' parameter is undefined. #106

dirkk0 opened this issue Nov 19, 2020 · 8 comments

Comments

@dirkk0
Copy link

dirkk0 commented Nov 19, 2020

Hi!

Great idea! But the exported project is not working here.

The console shows:
aframe-ar.js:2023 THREEx.ArMarkerControls: 'markersAreaEnabled' is not a property of this material.
and
aframe-ar.js:2016 THREEx.ArMarkerControls: 'minConfidence' parameter is undefined.

This was a Hiro marker plus glTF model in glb format.

I attached the project for reference.

Thanks, Dirk
ar.zip
@gciandro13
Copy link
Member

Seeing the logs I guess that this could be a problem related to arjs (I ask to @nicolocarpignoli )
We will focus on that and we'll give you update @dirkk0

Ty

@nicolocarpignoli
Copy link
Member

@dirkk0 those warnings should not be a problem.

Can you please host the project and give us:

  • a live example that we can run
  • the marker image, not only the .patt

I see no problems on the code but we need those two things in order to test better.

@dirkk0
Copy link
Author

dirkk0 commented Dec 1, 2020

Sure thing!
Here's the link to the hosted project:
http://curious-electric.com/_del/ar-test/
and this is the marker:
https://stemkoski.github.io/AR-Examples/markers/hiro.png

Just for reference, the Stemkoski examples are working:
https://stemkoski.github.io/AR-Examples/

@nicolocarpignoli
Copy link
Member

the problem is that you are using a HIRO marker but as a 'pattern' marker. Artoolkit fails to recognize it (if you look the .patt file with VSCode you will see the 'hiro' letters are not interpreted).

So you either use a different marker (like the default that Studio suggests you) ore you modify your code (HTML) in order to handle the default HIRO marker (you can find examples on the AR.js docs ) like this:

<!DOCTYPE html>
<html>
  <script src="https://aframe.io/releases/1.0.4/aframe.min.js"></script>
  <!-- we import arjs version without NFT but with marker + location based support -->
  <script src="https://raw.githack.com/AR-js-org/AR.js/master/aframe/build/aframe-ar.js"></script>
  <body style="margin : 0px; overflow: hidden;">
    <a-scene embedded arjs>
      <a-marker preset="hiro">
        <a-entity
          position="0 0 0"
          scale="0.05 0.05 0.05"
          gltf-model="https://arjs-cors-proxy.herokuapp.com/https://raw.githack.com/AR-js-org/AR.js/master/aframe/examples/image-tracking/nft/trex/scene.gltf"
        ></a-entity>
      </a-marker>
      <a-entity camera></a-entity>
    </a-scene>
  </body>
</html>

(consider only the preset='hiro' part and replace only that)

@dirkk0
Copy link
Author

dirkk0 commented Dec 1, 2020

Ah ok, thanks for looking into this.
Programming this myself/ changing the code is not a problem for me, I did so several times before.

But I liked the idea of having a wizard doing that without having to bother with code.
The wizard prompts me to upload an image as a marker, which I did.
So I guess this is an issue with Studio's wizard, right?
image

@nicolocarpignoli
Copy link
Member

Yes, it's a particular case when the user uploads on of the 'two' premade markers (Hiro and Kanjii ones). In those case, it may fail :)

@nicolocarpignoli
Copy link
Member

@gciandro13 we should modify the 'guide' (the linked one) and state to NOT use HIRO marker (also include the HIRO marker image as a lot of users mistake this with barcodes).

Please open a new issue with this little enhancement

@gciandro13 gciandro13 mentioned this issue Dec 1, 2020
Open
@gciandro13
Copy link
Member

Related issue: #109

Thanks @dirkk0 @nicolocarpignoli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dirkk0 @gciandro13 @nicolocarpignoli