You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
A feature that lets end users able to edit the name of the dispatch via the UI on the frontend. Since we are implementing sub-lattices feature, the naming will be easily identified between normal lattice and sub lattice.
Impacted components
Backend APIs and models of the web app (maintained by Team Psi)
Covalent data store models (maintained by Team AQ)
Alembic revisions (maintained by Team AQ, Team Psi will / can take over generating the revision files)
Front-End / UI component modifications for accepting user input
Impacted files
covalent/_data_store/models.py
a. To modify for adding the new column
b. Alembic configuration will pick the db reference from here
covalent/_results_manager/result.py
a. Modification to Json data before sending to the database
covalent/_results_manager/write_result_to_db.py
a. save and commit the data to db
covalent_ui/api/v1/database/schema/lattices.py
a. Contains the db schema, similar to that in covalent/data_store/models.py
b. Adding a column, will required to be modified in both lattices.py ( managed by Team Psi ) as well as data_store/models.py ( managed by Team AQ )
covalent_ui/api/v1/database/models/lattices_model.py
a. Serves a query model to the lattice data layer
covalent_ui/api/v1/routes/endpoints/lattice_route.py
a. Add new API(s) to handle user input for dispatch_name
b. Existing API(s) to handle the modification of the schema and model for the new column ( dispatch_name )
Roadmap for backend component
Once this is stable, data_store/models and covalent_ui/models can be suggested to be merged and we can maintain a shared code base between AQ and Psiog
Pending decisions
Can we prefix the dispatch_name column for all the sub-lattices with the word, ":sublattice"? For instance, ":sublattice-get_info"
@mshkanth would it be possible to delay implementation of this until we enhance the API layer, so that fewer components will be impacted? This way both the front- and back-end can simply query a display name from an API.
@wjcunningham7 - You are proposing that such a dispatch name feature be owned by the dispatcher and that an API to retreive/write the dispatch name would be exposed as a dispatcher API and not a webapp API. Right?
This discussion was converted from issue #1069 on August 17, 2022 08:55.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Description
A feature that lets end users able to edit the name of the dispatch via the UI on the frontend. Since we are implementing sub-lattices feature, the naming will be easily identified between normal lattice and sub lattice.
Impacted components
Impacted files
covalent/_data_store/models.py
a. To modify for adding the new column
b. Alembic configuration will pick the db reference from here
covalent/_results_manager/result.py
a. Modification to Json data before sending to the database
covalent/_results_manager/write_result_to_db.py
a. save and commit the data to db
covalent_ui/api/v1/database/schema/lattices.py
a. Contains the db schema, similar to that in covalent/data_store/models.py
b. Adding a column, will required to be modified in both lattices.py ( managed by Team Psi ) as well as data_store/models.py ( managed by Team AQ )
covalent_ui/api/v1/database/models/lattices_model.py
a. Serves a query model to the lattice data layer
covalent_ui/api/v1/routes/endpoints/lattice_route.py
a. Add new API(s) to handle user input for dispatch_name
b. Existing API(s) to handle the modification of the schema and model for the new column ( dispatch_name )
Roadmap for backend component
Pending decisions
Can we prefix the dispatch_name column for all the sub-lattices with the word, ":sublattice"? For instance, ":sublattice-get_info"
Beta Was this translation helpful? Give feedback.
All reactions