You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Documentation: There's a lot of room for improvement when it comes to providing accurate and detailed information to users on how to use specific file transfer strategies. In the concepts page, we need to discuss and clearly explain why passing files=[] is a very convenient design choice for the users.
Functional tests: One note on the unit tests for the file transfer - it has higher coverage than average and the tests are well written. Especially, @poojithurao's S3 strategy tests are a very good example of mocking boto3 calls. That being said the file transfers are a very important module and functional tests are essentialto ensure that each of the strategies are working end-to-end.
documentationImprovements or additions to documentationtestAdding or updating testscovalent-osRelated to released features
1 participant
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
The file transfers can be improved in several ways:
files=[]
is a very convenient design choice for the users.Beta Was this translation helpful? Give feedback.
All reactions