From 458d7d1a2894de0c603136bb5820beaf29b1a93c Mon Sep 17 00:00:00 2001
From: gvolpe <giacomo.volpe@cern.ch>
Date: Wed, 15 Nov 2023 10:27:09 +0100
Subject: [PATCH] Minors

---
 .../HMPID/include/HMPID/HmpidTaskMatches.h    |  6 +----
 Modules/HMPID/src/HmpidTaskMatches.cxx        | 23 -------------------
 Modules/HMPID/src/clusters.json               |  2 +-
 3 files changed, 2 insertions(+), 29 deletions(-)

diff --git a/Modules/HMPID/include/HMPID/HmpidTaskMatches.h b/Modules/HMPID/include/HMPID/HmpidTaskMatches.h
index 22f643b7d3..539df222a6 100644
--- a/Modules/HMPID/include/HMPID/HmpidTaskMatches.h
+++ b/Modules/HMPID/include/HMPID/HmpidTaskMatches.h
@@ -24,11 +24,8 @@
 #include "ReconstructionDataFormats/MatchInfoHMP.h"
 #include "SimulationDataFormat/MCCompLabel.h"
 
-#include <TH1.h>
-#include <TProfile.h>
-#include <TH2.h>
-
 class TH1F;
+class TH2F;
 
 using namespace o2::quality_control::core;
 using GID = o2::dataformats::GlobalTrackID;
@@ -53,7 +50,6 @@ class HmpidTaskMatches : public TaskInterface
 
  private:
   void BookHistograms();
-  void getJsonParameters();
 
   std::shared_ptr<o2::globaltracking::DataRequest> mDataRequest;
   o2::globaltracking::RecoContainer mRecoCont;
diff --git a/Modules/HMPID/src/HmpidTaskMatches.cxx b/Modules/HMPID/src/HmpidTaskMatches.cxx
index 2c016536eb..06b019f35c 100644
--- a/Modules/HMPID/src/HmpidTaskMatches.cxx
+++ b/Modules/HMPID/src/HmpidTaskMatches.cxx
@@ -33,10 +33,6 @@
 #include "DataFormatsHMP/Cluster.h"
 #include "ReconstructionDataFormats/MatchInfoHMP.h"
 
-#ifdef WITH_OPENMP
-#include <omp.h>
-#endif
-
 namespace o2::quality_control_modules::hmpid
 {
 
@@ -44,7 +40,6 @@ HmpidTaskMatches::HmpidTaskMatches() : TaskInterface() {}
 
 HmpidTaskMatches::~HmpidTaskMatches()
 {
-  ILOG(Info, Support) << "destructor called" << ENDM;
   for (int iCh = 0; iCh < 7; iCh++) {
     delete mMatchInfoResidualsXTrackMIP[iCh];
     delete mMatchInfoResidualsYTrackMIP[iCh];
@@ -57,16 +52,11 @@ HmpidTaskMatches::~HmpidTaskMatches()
 
 void HmpidTaskMatches::initialize(o2::framework::InitContext& /*ctx*/)
 {
-  ILOG(Debug, Devel) << "initialize TaskMatches" << ENDM;
-
   mDataRequest = std::make_shared<o2::globaltracking::DataRequest>();
   mDataRequest->requestTracks(mSrc, false);
 
-  // getJsonParameters();
-
   BookHistograms();
 
-  // publish histograms (Q: why publishing in initalize?)
   for (int iCh = 0; iCh < 7; iCh++) {
 
     getObjectsManager()->startPublishing(mMatchInfoResidualsXTrackMIP[iCh]);
@@ -78,10 +68,6 @@ void HmpidTaskMatches::initialize(o2::framework::InitContext& /*ctx*/)
     getObjectsManager()->setDisplayHint(mMatchInfoClusterMIPMap[iCh], "colz");
     getObjectsManager()->startPublishing(mMatchInfoThetaCherenkovVsMom[iCh]);
   }
-
-  ILOG(Info, Support) << "START DOING QC HMPID Matches" << ENDM;
-
-  // here do the QC
 }
 
 void HmpidTaskMatches::startOfActivity(const Activity& /*activity*/)
@@ -97,8 +83,6 @@ void HmpidTaskMatches::startOfCycle()
 
 void HmpidTaskMatches::monitorData(o2::framework::ProcessingContext& ctx)
 {
-  ILOG(Info, Support) << "monitorData" << ENDM;
-
   mRecoCont.collectData(ctx, *mDataRequest.get());
 
   // HMP
@@ -137,7 +121,6 @@ void HmpidTaskMatches::monitorData(o2::framework::ProcessingContext& ctx)
 
 void HmpidTaskMatches::endOfCycle()
 {
-
   ILOG(Debug, Devel) << "endOfCycle" << ENDM;
 }
 
@@ -176,10 +159,4 @@ void HmpidTaskMatches::reset()
     mMatchInfoThetaCherenkovVsMom[iCh]->Reset();
   }
 }
-
-void HmpidTaskMatches::getJsonParameters()
-{
-  ILOG(Info, Support) << "GetJsonParams" << ENDM;
-}
-
 } // namespace o2::quality_control_modules::hmpid
diff --git a/Modules/HMPID/src/clusters.json b/Modules/HMPID/src/clusters.json
index b45c9cdc53..46c79ea16f 100644
--- a/Modules/HMPID/src/clusters.json
+++ b/Modules/HMPID/src/clusters.json
@@ -25,7 +25,7 @@
       "tasks":{
          "TaskClusters":{
             "active":"true",
-            "className":"o2::quality_control_modules::hmpid::HmpidTaskPippo",
+            "className":"o2::quality_control_modules::hmpid::HmpidTaskClusters",
             "moduleName":"QcHMPID",
             "detectorName":"HMP",
             "cycleDurationSeconds":"10",