Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "End Session" doesn't actually end the session #6264

Open
1 task done
pandalion98 opened this issue Jan 14, 2025 · 5 comments
Open
1 task done

[Bug]: "End Session" doesn't actually end the session #6264

pandalion98 opened this issue Jan 14, 2025 · 5 comments
Labels
bug Something isn't working frontend Related to frontend severity:low Minor issues or affecting single user

Comments

@pandalion98
Copy link

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

When switching models in the settings window, the following question gets asked:

End Session
Changing your settings will clear your workspace and start a new session. Are you sure you want to continue?

Clicking "End Session" takes me back to the home screen. The issue here is that the old Docker agents are actually still running

root@debian:~# docker ps
CONTAINER ID   IMAGE                                                                       COMMAND                  CREATED          STATUS          PORTS     NAMES
48007a0027e6   ghcr.io/all-hands-ai/runtime:oh_v0.19.0_j4hs5zx4rwi2w13x_diqd851mcbpmq2ei   "/openhands/micromam…"   9 minutes ago    Up 9 minutes              openhands-runtime-e0e1b6c0aa2b48a6a69ba48de827a897
f103c4b04e99   ghcr.io/all-hands-ai/runtime:oh_v0.19.0_j4hs5zx4rwi2w13x_diqd851mcbpmq2ei   "/openhands/micromam…"   11 minutes ago   Up 11 minutes             openhands-runtime-66abac90803a478f849a188f965ac727
d0b2bd6cbd36   ghcr.io/all-hands-ai/runtime:oh_v0.19.0_j4hs5zx4rwi2w13x_diqd851mcbpmq2ei   "/openhands/micromam…"   24 minutes ago   Up 24 minutes             openhands-runtime-26c39a0900a241db89b6f9f08ff95812

Creating/opening a project starts yet another agent, burning resources.

I found this out when I was investigating why my usage credits on a popular LLM provider kept increasing. It turns out one of those containers were still working when I thought it was already ended.

OpenHands Installation

Development workflow

OpenHands Version

main

Operating System

None

Logs, Errors, Screenshots, and Additional Context

image

@pandalion98 pandalion98 added the bug Something isn't working label Jan 14, 2025
@mamoodi mamoodi added frontend Related to frontend severity:low Minor issues or affecting single user labels Jan 14, 2025
@mamoodi
Copy link
Collaborator

mamoodi commented Jan 14, 2025

The problem here is the message that appears. We actually don't want the session to end because of the multi conversation feature that is in the works.

@rbren or @amanape should we change the message that appears or remove it altogether?

@pandalion98
Copy link
Author

Start New Session
Changes to your settings will only apply to new sessions. How would you like to continue?

  • Create New Session
  • Cancel

Maybe a small disclaimer as well while the multi-session feature is still being developed.

@mamoodi
Copy link
Collaborator

mamoodi commented Jan 14, 2025

Yeah that's definitely a more accurate message. I'll let the folks I tagged chime in.

@rbren
Copy link
Collaborator

rbren commented Jan 14, 2025

I think we should just change this text to

Changes to your settings will only affect new or resurrected conversations. Running conversations will be unaffected.

Screenshot 2025-01-14 at 12 50 30 PM

@rbren
Copy link
Collaborator

rbren commented Jan 14, 2025

And not have any warning when you click "save"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to frontend severity:low Minor issues or affecting single user
Projects
None yet
Development

No branches or pull requests

3 participants