Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Damage to Shields by Multiplier #329

Open
2 of 5 tasks
UltimaOath opened this issue Nov 16, 2021 · 8 comments
Open
2 of 5 tasks

Increase Damage to Shields by Multiplier #329

UltimaOath opened this issue Nov 16, 2021 · 8 comments
Assignees
Labels
priority: low Low priority status: confirmed Confirmed by a maintainer status: on hold Other things need to be resolved before progress can continue type: improvement Add or adjust a feature
Milestone

Comments

@UltimaOath
Copy link
Collaborator

UltimaOath commented Nov 16, 2021

  apply-settings:
    multipliers:
      shield-damage: 1.0   # 100% increase in damage to shields at maxLevel

This setting references:
https://hub.spigotmc.org/javadocs/spigot/org/bukkit/EntityEffect.html#SHIELD_BLOCK

When an entity hits a shield, the damage to the shield can be increased by a percentage.

Edit by @lokka30 tracking issue progress:

  • Implemented entity data code in API
  • Implement shield damage modifier in listener
    • Establish most of the implementation
    • Gain ability to modify shield damage linked via EntityDamageEvent (github.com/PaperMC/Paper/issues/8751)
    • Implement the small remaining part
@UltimaOath UltimaOath added the type: improvement Add or adjust a feature label Nov 16, 2021
@lokka30

This comment was marked as resolved.

@lokka30 lokka30 self-assigned this Jan 9, 2022
@lokka30 lokka30 added priority: low Low priority status: on hold Other things need to be resolved before progress can continue status: unconfirmed Needs confirmation status: waiting for poster Further information from the poster (user) is needed labels Jan 9, 2022
@lokka30 lokka30 removed the status: on hold Other things need to be resolved before progress can continue label Jan 18, 2022
@UltimaOath

This comment was marked as resolved.

@lokka30

This comment was marked as resolved.

@UltimaOath
Copy link
Collaborator Author

My suggestion is one where, if the damage is blocked by a shield, the damage that the shield would take from this event would increase proportionate to their shield-damage attribute. For example, if the config was set to 2.0 and assuming a max level entity, then when an entity attacked a player and the player successfully blocked the attack with their shield, when that shield receives damage from the event, we would multiply that damage 200%

@lokka30

This comment was marked as resolved.

@lokka30 lokka30 closed this as completed Jan 18, 2022
@UltimaOath

This comment was marked as resolved.

@lokka30
Copy link
Member

lokka30 commented Jan 2, 2023

Bukkit API does not contain the code we require to implement this feature. See github.com/PaperMC/Paper/issues/8751.

@lokka30
Copy link
Member

lokka30 commented Jan 2, 2023

Apologies for bouncing around opening and closing these issues. I'll leave this open so I can close #424 and so this can be resolved once it is possible to do so (which may not happen in LM4.0, or ever).

@lokka30 lokka30 reopened this Jan 2, 2023
@lokka30 lokka30 added status: on hold Other things need to be resolved before progress can continue status: confirmed Confirmed by a maintainer and removed status: waiting for poster Further information from the poster (user) is needed status: unconfirmed Needs confirmation labels Jan 2, 2023
@lokka30 lokka30 added this to the v4.0 milestone Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Low priority status: confirmed Confirmed by a maintainer status: on hold Other things need to be resolved before progress can continue type: improvement Add or adjust a feature
Projects
None yet
Development

No branches or pull requests

2 participants