Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add "Archive Current Page" #26

Open
ludos1978 opened this issue Jun 28, 2024 · 11 comments · May be fixed by #31
Open

Suggestion: Add "Archive Current Page" #26

ludos1978 opened this issue Jun 28, 2024 · 11 comments · May be fixed by #31

Comments

@ludos1978
Copy link

ludos1978 commented Jun 28, 2024

From my usage experience (a week), i mostly want to archive a page i currently have open. Up till now i never used the url-regex system.

So my suggestion is to add the buttons to archive the current page, to the default window.

@tjhorner
Copy link
Collaborator

There is a context menu item available for this. Right click anywhere on the page and you should see "ArchiveBox Exporter" > "Archive Current Page" in the list.

@huyz
Copy link

huyz commented Jul 29, 2024

One can also right-click on the menubar icon.

I do wish there were a button on the pop-up window for Archive current page. Also a keyboard shortcut would be nice

@pirate
Copy link
Member

pirate commented Jul 29, 2024

Both are good ideas, I think both are fairly easy to add with a couple handler funcs and one-line changes to manifest.json. If anyone wants to contribute this I think it can be done by copy pasting in the source code and asking ChatGPT what changes to make. PRs welcome :)

@huyz
Copy link

huyz commented Jul 30, 2024

Oh I could try this for keyboard shortcut: ArchiveBox/ArchiveBox#1248

@pirate
Copy link
Member

pirate commented Jul 30, 2024

I wouldn't do it that way, there is a keyboard shortcuts API built into extensions already, it's very simple and just requires one line in manifest.json defining the default key combo + a handler function to call when it's pressed.

The benefit of using the native API is chrome provides the UI to change the default key combo to something else.

@huyz
Copy link

huyz commented Aug 6, 2024

I wrote:

One can also right-click on the menubar icon.

Actually, that method doesn't work for some reason. No matter, most people won't know about this "Archive Current Page" path anyway.

@ pirate wrote:

I wouldn't do it that way, there is a keyboard shortcuts API built into extensions already

Yeah for sure. I just meant for myself until it's supported in the extension.
If I have some time I'll try to do a PR for the extension.

@ludos1978
Copy link
Author

I must have been very unclear in my description. I do think it would be way better to have the "archive current page" on the left click, instead of having it on the right click.

Currently a left click leads to a window that gives advances settings and options but not the most important basic functions.

My suggestion was to add a Button "Archive current page" to the window that opens on the left click.

@huyz
Copy link

huyz commented Aug 6, 2024

@ludos1978 You were very clear. It's me who confused you with my right-click suggestion (which I later retracted). We're all on the same page: we want to be able to quickly add the current page with a left-click on the icon.

@ludos1978
Copy link
Author

A good inspiration might be the wayback-machine browser plugin.

Not sure which features are required, but a big button on top would be a great solution :-)

Bildschirmfoto 2024-08-06 um 16 35 27

@Steering7253
Copy link

Steering7253 commented Oct 18, 2024

Actually, that method doesn't work for some reason. No matter, most people won't know about this "Archive Current Page" path anyway.

Because the pageUrl is not available to toolbar context menu entries. This entry should not be displayed on 'all' context menus. (IMO it shouldn't be displayed in any context menus, I don't really want even more context menu entries overflowing the screen when I right click on a page, although that's Chrome's fault)

https://stackoverflow.com/a/14251218/2283305

(Also the context menu, even right clicking on the page, also doesn't work in some cases like when you're looking at a PDF in Chrome's built-in viewer)

@Steering7253
Copy link

Something like Steering7253@793c0a2

(BTW package.json is malformed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants