Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Feature Request - Add validation to Accelerator workflows #536

Closed
MilesCameron-DMs opened this issue May 22, 2023 · 3 comments
Closed
Assignees
Milestone

Comments

@MilesCameron-DMs
Copy link
Contributor

Describe the solution you'd like

Add validation to the accelerator workflows using whatif and environments in GitHub.

I have tested this and despite the issues set out in #249 it allows some validation before deploying to production and is relatively easy to implement.

Describe alternatives you've considered

None.

Additional context

How i implemented:

  1. Copied the Deploy-* pipeline scripts and renamed to Validate-*
  2. Amended Validate-* to use whatif
  3. Amended the workflow to run a validate job using the new validate PowerShell scripts
  4. Added a production environment to the GitHub repo
  5. Configure the Required reviewers protection rule on the environment

Workflow:

  • Create a feature branch
  • Commit and create a pull request
  • Workflow runs validation using whatif
  • Workflow pauses due to protection rule - time to review the whatif
  • Once the whatif is reviewed and we are happy with the change, approve the deployment.
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 22, 2023
@jtracey93 jtracey93 added Area: Accelerator and removed Needs: Triage 🔍 Needs triaging by the team labels May 22, 2023
@oZakari
Copy link
Contributor

oZakari commented May 22, 2023

Hey @MilesCameron-DMs, thanks for submitting this and for sharing your approach. This is on my backlog, but if you would like to create a PR using the pipeline scripts you created that would be appreciated as well!

@MilesCameron-DMs
Copy link
Contributor Author

Created PR: #539

I amended it slightly so it just re-uses the Deploy-* pipeline scripts and just passes a boolean for whatif

@jtracey93 jtracey93 added this to the v0.15.0 milestone May 31, 2023
@oZakari oZakari mentioned this issue Jul 21, 2023
10 tasks
@oZakari
Copy link
Contributor

oZakari commented Jul 21, 2023

Merged #539 - Another backlog item to add What-if output to PR comments.

@oZakari oZakari closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants