Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a second base class to handle mixed spectrum models #13

Open
lcwheeler opened this issue Apr 26, 2018 · 3 comments
Open

Create a second base class to handle mixed spectrum models #13

lcwheeler opened this issue Apr 26, 2018 · 3 comments

Comments

@lcwheeler
Copy link
Member

No description provided.

@jharman25
Copy link
Member

Zach and I chatted about this earlier today - We're thinking we should write an entirely new BaseMixedSpectrum class that uses the same logic as BaseSpectrum but iterates over combinations of lineshapes. For example, if you have 2 peaks, it would iterate over fitting 1) two gaussians, 2) one gaussian and one lorentzian, and 3) two lorentzians. Then have some sort of scoring function to pick the best combination and spit that out as the best model. In the works!

@lcwheeler
Copy link
Member Author

Makes sense to me! Maybe could do a likelihood ratio test between the different combos, or something similar?

@jharman25
Copy link
Member

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants