Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-sprite limb darkening implementation #1830

Open
Askaniy opened this issue Aug 4, 2023 · 0 comments
Open

Non-sprite limb darkening implementation #1830

Askaniy opened this issue Aug 4, 2023 · 0 comments
Labels

Comments

@Askaniy
Copy link
Contributor

Askaniy commented Aug 4, 2023

The current limb darkening implementation seems to work by placing the sprite in front of the star, which increases the brightness in the center:
изображение
Compared to photographs, it is noticeably unnatural. Two solutions have been proposed on the Discord:

  1. Use the empirical formula as in section 2.4 of this article.
  2. Or, more correctly, make the effect dependent on the angle.

CubicApocalypse about the second way:

I'd think angle-based would be relatively easy, using the same view angle/Fresnel effect that basically every game ever uses for pretty much anything
the old HazeColor effect worked the same way, more or less

TTarrants:

Fortunately the limb-darkening laws' coefficients are basically temperature (and metallicity) dependant, so it would be feasible to add them in a nice, "realistic" way in Celestia. M dwarfs having more pronounced limb-darkening than early-type stars, etc.

@375gnu 375gnu added enhancement New feature or request renderer wishlist labels Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants