plugin loadByIdOrUUID doesn't load enough data for a video listing

[ppom0]

Describe the problem to be solved

First thanks for providing this awesome software!

---

Context: I just wrote a plugin permitting to have a random listing of the videos.

I registered my handler on this hook: filter:api.videos.list.result.

I had to recreate the listing myself, getting rid of the provided one, because shuffling a paginated list is not a good random: each section of 25 videos will be shuffled, but they'll stay in the same global order.

So here's my attempt:

	registerHook({
		target: 'filter:api.videos.list.result',
		handler: async (result, params) => {
			if (!params.random) return result;

			// We use the current day as random seed
			const now = new Date();
			const seed = "0." + (now.getFullYear() * 365 + now.getMonth() * 31 + now.getDate());

			const q = await database.query(
				"SELECT setseed(:seed);" +
				"SELECT id FROM video ORDER BY random() OFFSET :start LIMIT :count;",
				{
					type: 'SELECT',
					replacements: {
						seed,
						start: params.start,
						count: params.count,
					}
				}
			);

			// Get ids of SQL request
			const ids = Object.values(q).filter(elt => elt.id).map(elt => elt.id);

			// Fetch all videos
			const thumbnails = await Promise.all(
				ids.map(id => videos.loadByIdOrUUID(id))
			);

			return { data: thumbnails };
		},
	});

Problem is that the client app requires channel and author attributes on those objects.

So for now I hard-coded the values, which is very hacky:

			// This code is inserted before the return
			thumbnails
				.forEach(elt => {
					elt.VideoChannel = {
						toFormattedSummaryJSON: function() {
							return {
								// Hardcoded data
							}
						}
					};

					elt.VideoChannel.Account = {
						toFormattedSummaryJSON: function() {
							return {
								// Hardcoded data
							}
						}
					};
				});

Describe the solution you would like

Either having a new loadByIdOrUUIDWithChannelAndAuthor or adding this data to the existing function would permit this!

What do you think?