Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only grab single version of full size image url #13

Open
patcon opened this issue Jun 1, 2022 · 0 comments
Open

Only grab single version of full size image url #13

patcon opened this issue Jun 1, 2022 · 0 comments

Comments

@patcon
Copy link
Member

patcon commented Jun 1, 2022 •
edited
Loading

Re-ticketed from Slack msg

Currently, this gets scraped:

        "PageImages": [
            "https://www.services.rcmp-grc.gc.ca/missing-disparus/showImage?id=2064&thumb=medium",
            "https://www.services.rcmp-grc.gc.ca/missing-disparus/showImage?id=2064&thumb=small",
            "https://www.services.rcmp-grc.gc.ca/missing-disparus/showImage?id=2065&thumb=medium",
            "https://www.services.rcmp-grc.gc.ca/missing-disparus/showImage?id=2065&thumb=small"
        ],

but this would actually return the full image:

https://www.services.rcmp-grc.gc.ca/missing-disparus/showImage?id=2065

We should dedup and strip the thumb query param
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patcon