inference failure when broadcasting over multiple structs and a Field

[juliasloan25]

Describe the bug

Reproducer added in #2062
Initially found in CliMA/ClimaLand.jl#739

This is a type inference error that arises when a function is broadcast over one field and two structs that both have broadcastable extended using tuple. The types in the expression become too complex, and inference fails. The problem is simplified in the reproducer so the structs each contain one scalar value, and the called function itself does nothing. The reproducer was tested on fields constructed on multiple different spaces, and reproduced the bug on all of them.

[charleskawczynski]

This is becoming more of an issue as we eliminate the ClimaAtmos solver cache. So, I think it's worth either fixing this or opening an issue in julialang.

Here is a pretty low-level reproducer, with only datalayouts (and arrays):

import ClimaCore: DataLayouts
import Base.Broadcast: broadcastable,
	BroadcastStyle,
	AbstractArrayStyle,
	Broadcasted,
	instantiate,
	broadcasted,
	materialize,
	materialize!

struct MyParams1{A}
  a::A
end;
struct MyParams2{B}
  b::B
end;
Base.Broadcast.broadcastable(x::MyParams1) = tuple(x);
Base.Broadcast.broadcastable(x::MyParams2) = tuple(x);

foo(f, p1, p2) = f + p1.a - p2.b;
bar(p1, p2, f) = f + p1.a - p2.b;

FT = Float64;
p1 = MyParams1{FT}(1);
p2 = MyParams2{FT}(2);

b = zeros(FT, 5,5); # works
a = similar(b);
bc = instantiate(broadcasted(foo, b, p1, p2));
materialize!(a, bc)
using JET; @test_opt materialize!(a, bc) # also passes inference

b = DataLayouts.VIJFH{FT}(Array{FT}, zeros; Nv=4, Nij=4, Nh=4); # ClimaCore CPU array works
a = similar(b);
bc = instantiate(broadcasted(foo, b, p1, p2));
materialize!(a, bc)
using JET; @test_opt materialize!(a, bc) # also passes inference

import CUDA;
b = CUDA.zeros(FT, 5,5); # cu-array works
a = similar(b);
bc = instantiate(broadcasted(foo, b, p1, p2));
materialize!(a, bc)

import CUDA;
b = DataLayouts.VIJFH{FT}(CUDA.CuArray{FT}, zeros; Nv=4, Nij=4, Nh=4);
a = similar(b);
bc = instantiate(broadcasted(foo, b, p1, p2));
materialize!(a, bc) # fails

nothing