Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate PyMeshLab for meshing_repair_non_manifold_vertices #431

Open
JansenSmith opened this issue Nov 8, 2024 · 5 comments
Open

integrate PyMeshLab for meshing_repair_non_manifold_vertices #431

JansenSmith opened this issue Nov 8, 2024 · 5 comments
Assignees

Comments

@JansenSmith
Copy link
Member

ms.meshing_repair_non_manifold_vertices(vertdispratio = 0.010000)
running this twice fixes most STLs with duplicated vertices

Here is a clean pr adding SceneBuilder as an example of all the bits that need to be touched:
#409

Process is documented here: #412

MeshLab is a utility, so it would just require an additional json in ExternalEditorsBowlerStudio and a static class call in:
https://github.com/CommonWealthRobotics/bowler-script-kernel/blob/kh/add-cadoodle/src/main/java/com/neuronrobotics/bowlerstudio/util/GeometrySimplification.java

@JansenSmith JansenSmith self-assigned this Nov 8, 2024
@JansenSmith
Copy link
Member Author

actually..... i've found some that require multiple runs of meshing_repair_non_manifold_vertices....
instead, use PyMeshLab to find non-manifold vertices and iterate until number is zero.

@JansenSmith
Copy link
Member Author

actually..... i've found some that require multiple runs of meshing_repair_non_manifold_vertices....
still researching

@madhephaestus
Copy link
Member

You may want to look at the source of the exception you are trying to correct and see if maybe you can avoid the problem upstream of the repair: https://github.com/NeuronRobotics/JCSG/blob/development/src/main/java/eu/mihosoft/vrl/v3d/Plane.java#L106

@madhephaestus
Copy link
Member

I need a small file <1mb that produces the problem for unit testing

@madhephaestus
Copy link
Member

the root cause may have been fixed in this commit: NeuronRobotics/JCSG@5974f4a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants