Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAR files extract corrupted files if the filenames are not encrypted #1

Open
DeltaJordan opened this issue Jun 5, 2017 · 1 comment
Assignees
Labels

Comments

@DeltaJordan
Copy link
Owner

DeltaJordan commented Jun 5, 2017

When a file from the viewing window of the program is opened or extracted from a password-protected rar file, the resulting file is corrupted. The problem is the library this application uses to open the archive, SharpCompress, does not have a check for passwords for rars and also does not have validation for file data, like CRC. I may have to find a way to validate the file, possibly by the file size because it seems to create an empty file.

Need to keep an eye on CRC Validation support in SharpCompress: adamhathcock/sharpcompress#246

@DeltaJordan DeltaJordan added the bug label Jun 5, 2017
@DeltaJordan
Copy link
Owner Author

DeltaJordan commented Jun 5, 2017

Added filesize check 51c2130 which fixes the error for the extract button in my tests. Still need to fix it in the the drag-drop handler

@DeltaJordan DeltaJordan self-assigned this Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant