*brackets-storage (brackets-memory-db)* Handling for assign value to match opponent which original value is possibly null

[yongshun950824]

This question is on brackets-storage, but there is no discussion in that Repo, so I question in brackets-manager Repo.

Scenario:

I have bracket data that has possible no opponent in a match/match game, indicate BYE. When I update the match/match game, I hit the error below:

Screenshot 1

When I debugging,

Screenshot 2

When execute this line

Object.assign(existing[key], value[key]);

With existing[key] is null, I will get the error (in Screenshot 1).

The below code is the fix for Drarig29/brackets-storage@f1cb82e

https://github.com/Drarig29/brackets-storage/blob/30f45dc8eb4fa5b0df411d517aa78ab473560d75/brackets-memory-db/index.ts#L216

The below code is what I demonstrate the situation in Screenshot 2

Screenshot 3

So I suspect that the code in L216 didn't handle correctly especially when r[t] is null.

[Drarig29]

Today I tried to run the brackets-manager unit tests with only the InMemoryDatabase (brackets-memory-db) and ran into some issues in addition to those you speak about in this discussion.

Now, all the tests are passing and hopefully this should be the last issue with this package.

You can now use brackets-memory-db@1.0.4 and brackets-viewer@1.4.7 🎉