Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PAL12L6 devices #4

Open
shift838 opened this issue Jan 1, 2024 · 2 comments
Open

Support for PAL12L6 devices #4

shift838 opened this issue Jan 1, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@shift838
Copy link

shift838 commented Jan 1, 2024

Any plans to support PAL12L6 devices with the v2 board?

@hkzlab hkzlab added enhancement New feature or request good first issue Good for newcomers labels Jan 2, 2024
@hkzlab
Copy link
Member

hkzlab commented Jan 2, 2024

I'm quite busy with other projects in these days, was planning to get back to the DuPAL one day, with the intention of rewriting the analyzer from scratch.

Still, there should be support for PAL16H2 in both the analyzer and the espresso converter, which is almost identical to a 12L6 except that it is an active-high device.

You could try copying https://github.com/DuPAL-PAL-DUmper/DuPAL_Analyzer/blob/master/src/main/java/info/hkzlab/dupal/analyzer/devices/PAL12H6Specs.java to a PAL12L6Specs.java file, change what isActiveLow() returns, the PAL_TYPE string, then wire it up in the palTypes of App.java.
Should be straightforward.

This needs to be done for the EspressoConverter too if it has to support the same device.

@hkzlab
Copy link
Member

hkzlab commented Jan 2, 2024

@shift838 I had some time in the evening to perform the changes.
It's untested, but PAL12L6 should be an option now, you can try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants