Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Internationalization Cleanup #104

Open
1 task done
keithrfung opened this issue Jan 10, 2022 · 1 comment
Open
1 task done

🧹 Internationalization Cleanup #104

keithrfung opened this issue Jan 10, 2022 · 1 comment
Labels
code owner only Only for Code Owner enhancement New feature or request

Comments

@keithrfung
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Suggestion

Connect i8n and material localization

Possible Implementation

No response

Anything else?

No response
@keithrfung keithrfung added enhancement New feature or request triage Waiting to be triaged code owner only Only for Code Owner and removed triage Waiting to be triaged labels Jan 10, 2022
@lprichar
Copy link
Collaborator

This task should probably be updated to include the ability to see the site in another language, which it doesn't currently support. If I were to word it as a user story:

As a Spanish speaker I want to choose to see all text in the site in my native language

Implementation-wise I believe this means uncommenting out three lines of code src/index.tsx (for the admin site anyway that's packages/admin-app/src/index.tsx).

@lprichar lprichar mentioned this issue Jan 20, 2022
Merged
@lprichar lprichar mentioned this issue Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code owner only Only for Code Owner enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lprichar @keithrfung