Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of Apache "NOTICE" file #195

Open
nicopap opened this issue May 26, 2022 · 0 comments
Open

Handling of Apache "NOTICE" file #195

nicopap opened this issue May 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@nicopap
Copy link

nicopap commented May 26, 2022

Currently cargo-about doesn't really comply with the Apache-2.0 license. Apache has a whole section introducing and specifying how to handle NOTICE files (4.d) , I see no handling of NOTICE in cargo-about. I've read about 10 times the NOTICE section and it seems that having a reproduction of all the NOTICE files is required; though IANAL.

Someone using cargo-about will be in contravention of the conditions of the Apache license if any of their dependency has a NOTICE file. The legally conscientious user will need to manually go through all their Apache-licensed dependencies dragging for stray NOTICE files. This undermines a major functionality of the plugin.

Solution:
implement NOTICE handling by concatenating them and adding them to the output of cargo about generate.

@nicopap nicopap added the enhancement New feature or request label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant