Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric] Incompatibility with Immersive Portals #102

Open
AeiouEnigma opened this issue Jan 25, 2022 · 2 comments
Open

[Fabric] Incompatibility with Immersive Portals #102

AeiouEnigma opened this issue Jan 25, 2022 · 2 comments

Comments

@AeiouEnigma
Copy link
Contributor

Copy of Fabricators-of-Create/Create#53 and iPortalTeam/ImmersivePortalsMod#967, opened here at the recommendation of qouteall.

Extraordinary rendering issues occur when looking through an Immersive Portal while the Fabric version of Create is installed.

2022-01-22_15 57 10

Really I'm just hoping that by opening an issue here, maybe Jozufozu or Pepper can share some insight into what the cause of the issue could be.

@qouteall
Copy link

qouteall commented May 14, 2022

Flywheel destroy all GL resources when ImmPtl create another client world

https://github.com/Jozufozu/Flywheel/blob/1.18%2Ffabric%2Fdev/src/main/java/com/jozufozu/flywheel/mixin/LevelRendererMixin.java#L92

https://github.com/Jozufozu/Flywheel/blob/1.18%2Ffabric%2Fdev/src/main/java/com/jozufozu/flywheel/Flywheel.java#L68

Flywheel can make that event triggered in Minecraft.updateLevelInEngines so that it won't trigger when ImmPtl creates secondary client world and secondary world renderer. (But that solution is not perfect, it still needs to reset when reloading resourcepacks)
On immptl's side I can use hacky mixin to fix it temporarily.

@Nolij
Copy link

Nolij commented May 14, 2022

Flywheel destroy all GL resources when ImmPtl create another client world

https://github.com/Jozufozu/Flywheel/blob/1.18%2Ffabric%2Fdev/src/main/java/com/jozufozu/flywheel/mixin/LevelRendererMixin.java#L92

https://github.com/Jozufozu/Flywheel/blob/1.18%2Ffabric%2Fdev/src/main/java/com/jozufozu/flywheel/Flywheel.java#L68

Flywheel can make that event triggered in Minecraft.updateLevelInEngines so that it won't trigger when ImmPtl creates secondary client world and secondary world renderer. (But that solution is not perfect, it still needs to reset when reloading resourcepacks)
On immptl's side I can use hacky mixin to fix it temporarily.

Does it also do this on Forge, or is this just how it was done on Fabric?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants