Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet - Error for invalid IBAN should be "Invalid IBAN" instead of "400 invalid IBAN" #54751

Open
6 of 8 tasks
IuliiaHerets opened this issue Jan 2, 2025 · 10 comments
Open
6 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+394034@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: User Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Wallet.
  3. Click Add bank account.
  4. Select Madagascar > Next.
  5. Enter any invalid IBAN number.
  6. Enter the rest of the details and reach the confirmation page.
  7. Tick the checkbox on the confirmation page.
  8. Click Confirm.

Expected Result:

The error message should display "Invalid IBAN".

Actual Result:

The error message displays "400 Invalid IBAN".

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6705009_1735810703012.20250102_173501.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Jan 2, 2025
Copy link

melvin-bot bot commented Jan 2, 2025

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 2, 2025

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 2, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 2, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@cristipaval
Copy link
Contributor

Minor issue that needs a backend fix.

@MitchExpensify
Copy link
Contributor

@IuliiaHerets I don't see a 400 error in the video, am I missing something?

@IuliiaHerets
Copy link
Author

IuliiaHerets commented Jan 3, 2025

@MitchExpensify Can you please check the last 5 seconds of the video?
image

@Tony-MK
Copy link
Contributor

Tony-MK commented Jan 3, 2025

I believe this needs a simple backend fix because api/BankAccount_CreateCorpay? is returning "400 invalid IBAN" as the error message.

While it should just return "Invalid IBAN".

Screenshot 2025-01-03 at 19 31 03

Copy link

melvin-bot bot commented Jan 7, 2025

@cristipaval, @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@cristipaval
Copy link
Contributor

^Backend fix is ready for review

@melvin-bot melvin-bot bot removed the Overdue label Jan 7, 2025
@cristipaval cristipaval added the Reviewing Has a PR in review label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants