Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Critical] Submitted Expense Incorrectly Added to Trip Report Instead of Workspace Chat #54788

Open
1 of 8 tasks
m-natarajan opened this issue Jan 3, 2025 · 7 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @blimpich
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

  1. Submit an expense that should be associated with a workspace chat.
  2. Observe that the expense is added to the open Trip Report instead of the intended workspace chat.

Expected Result:

The submitted expense should be correctly added to the intended workspace chat

Actual Result:

The submitted expense is incorrectly assigned to the Trip Report as its parent.
(Not able to reproduce this in a test account, but able to reproduce it consistently in main expensify production account)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Screen.Recording.2025-01-03.at.12.16.55.PM.mov

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jan 3, 2025
Copy link

melvin-bot bot commented Jan 3, 2025

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@blimpich
Copy link
Contributor

blimpich commented Jan 3, 2025

I tried reproducing this on staging by creating a workspace and enabling travel and creating a trip as per this SO. I wasn't able to reproduce it. I messed around with instant submit settings and also couldn't reproduce it. Not sure how to make this reproduce.

@blimpich
Copy link
Contributor

blimpich commented Jan 4, 2025

Marking this as Travel and "critical" since its a pretty bad bug IMO.

@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2025
@trjExpensify
Copy link
Contributor

@blimpich, perhaps @stitesExpensify or @rlinoz can help investigate with the data in your account?

@melvin-bot melvin-bot bot removed the Overdue label Jan 6, 2025
@stitesExpensify stitesExpensify changed the title Submitted Expense Incorrectly Added to Trip Report Instead of Workspace Chat [Critical] Submitted Expense Incorrectly Added to Trip Report Instead of Workspace Chat Jan 6, 2025
@blimpich
Copy link
Contributor

blimpich commented Jan 6, 2025

@blimpich
Copy link
Contributor

blimpich commented Jan 6, 2025

So I looked into this a little bit, takeaways so far:

  • something is really messed up on my account, still don't know how it happened
  • I can consistently reproduce the bug on my prod account, but haven't figured out how to reproduce it on a test account
  • when I submit an expense to Expensify - US the frontend passes an iouReportID that is the report id of a report that has a parentID of the San Francisco Onshore 2025 trip report. That seems weird to me, I'm not sure if it should be doing that, and maybe that's the bug and its a frontend issue? But hard to tell since I can't reproduce on a test account.

Next step: right now I'm waiting to see if the expenses that are erroneously submitted to the trip report can be manually moved over / fixed by my approver @saracouto. Once those are approved or deleted I should be able to narrow down if this is a frontend or backend bug by inspecting the network request/response of the RequestMoney command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed
Projects
Status: Critical - Feb '25 Earnings
Development

No branches or pull requests

4 participants