Update the invitation process to include the role of the person being invited to a workspace

[anmurali]

Workspace - Member - Invite member - select (or enter) email or phone number - add message

Let's add the role as the final step in the invitation process

@jamesdeanexpensify @shawnborton should we also change the title of this step?

[Shahidullah-Muffakir]

@anmurali If a user invites multiple members at once, should the selected role be applied to all the invited members?

[truph01]

Edited by proposal-police: This proposal was edited at 2025-01-04 02:33:28 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Update the invitation process to include the role of the person being invited to a workspace

What is the root cause of that problem?

• New feature

What changes do you think we should make in order to solve the problem?

• Add a input component which allow user to select the role in here:

                        <View style={{marginHorizontal: -20}}>
                            <InputWrapper
                                InputComponent={ValuePicker}
                                inputID={'role'}
                                label={'Role'}
                                items={[
                                    {label: 'Admin', value: 'admin'},
                                    {label: 'User', value: 'user'},
                                    {label: 'AUDITOR', value: 'auditor'},
                                ]}
                                value={role}
                                onValueChange={(value) => setRole(value)}
                            />
                        </View>

• In here:

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Line 103 in b23c478

Member.addMembersToWorkspace(invitedEmailsToAccountIDsDraft ?? {}, `${welcomeNoteSubject}\n\n${welcomeNote}`, route.params.policyID, policyMemberAccountIDs);

pass the above role value to Member.addMembersToWorkspace so that in:

App/src/libs/actions/Policy/Member.ts

Line 750 in b23c478

API.write(WRITE_COMMANDS.ADD_MEMBERS_TO_WORKSPACE, params, {optimisticData, successData, failureData});

we can use the role data to:

1. Update the optimistic data in:

App/src/libs/actions/Policy/Member.ts

Line 691 in b23c478

role: CONST.POLICY.ROLE.USER,

instead of default user.

2. Send the role data to BE via:

App/src/libs/actions/Policy/Member.ts

Line 750 in b23c478

API.write(WRITE_COMMANDS.ADD_MEMBERS_TO_WORKSPACE, params, {optimisticData, successData, failureData});

• These are the primary steps required to implement this feature. The detailed implementation can be addressed during the PR phase.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[parasharrajat]

@truph01 The Proposal looks good to me. I believe that role would be assigned to all invited members.

[shawnborton]

should we also change the title of this step?

@anmurali what are you thinking to change it to? Perhaps something like "Confirm invite"?

[melvin-bot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!