Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - "Default" label tooltip content is truncated when language is Spanish #54955

Open
2 of 8 tasks
IuliiaHerets opened this issue Jan 8, 2025 · 3 comments
Open
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.82-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): ojidojdmwowj22doj@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • App language is Spanish.
  • There is a default workspace.
  1. Go to staging.new.expensify.com
  2. Go to Account settings.
  3. Go to Espacios de trabajo (Workspaces).
  4. Hover over Predeterminado (Default).

Expected Result:

The tooltip content should not be truncated.

Actual Result:

"Default" label tooltip content is truncated when language is Spanish.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6708976_1736335746760!Screenshot_2025-01-08_at_19 22 58
Bug6708976_1736335746757.20250108_192238.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 8, 2025
Copy link

melvin-bot bot commented Jan 8, 2025

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Krishna2323
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - "Default" label tooltip content is truncated when language is Spanish

What is the root cause of that problem?

  • Number of lines is not specified here.

<Tooltip
maxWidth={variables.w184}
text={translate('workspace.common.defaultNote')}
>

What changes do you think we should make in order to solve the problem?

  • We can pass numberOfLines with 4, 5 or any desired number as value.
  • Or we can increase the width of the tooltip.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?


What alternative solutions did you explore? (Optional)

@NJ-2020
Copy link
Contributor

NJ-2020 commented Jan 8, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - "Default" label tooltip content is truncated when language is Spanish

What is the root cause of that problem?

We do not pass numberOfLines 0 since the default is 3

<Tooltip
maxWidth={variables.w184}
text={translate('workspace.common.defaultNote')}
>

What changes do you think we should make in order to solve the problem?

We should pass numberOfLines 0, so the text would not get truncate

<Tooltip
maxWidth={variables.w184}
text={translate('workspace.common.defaultNote')}
>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?


What alternative solutions did you explore? (Optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants