Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[orchestra2md] Incorrect conversion of appinfo element for FIXML #68

Open
kleihan opened this issue Sep 5, 2022 · 4 comments
Open

[orchestra2md] Incorrect conversion of appinfo element for FIXML #68

kleihan opened this issue Sep 5, 2022 · 4 comments
Assignees
Labels
bug Something isn't working fixed Issue has been resolved, awaits testing

Comments

@kleihan
Copy link
Member

kleihan commented Sep 5, 2022

Tablature v1.0.2 does not process <fixr:appinfo purpose="FIXML"> correctly. It creates a column "Fixml" with content /P/[fixml:FIXMLencodingType: null]/P/ in markdown. Expected behavior is that it ignores such appinfo elements. They are not needed in markdown and are only for internal purposes to create the FIXML schemas.

@kleihan kleihan added the bug Something isn't working label Sep 5, 2022
@donmendelson
Copy link
Member

No, appinfo is not just for internal use. It was intended that firms could extend their ROE with attributes of their own that are not predefined in Orchestra.

However, it would be possible to add a feature to suppress appinfo if desired.

@kleihan
Copy link
Member Author

kleihan commented Sep 6, 2022

I was not precise enough when i said "such appinfo elements". I meant to say "appinfo elements with purpose FIXML". It is not about suppressing all appinfo elements. Tablature still has a problem with the conversion of appinfo that contains XML snippets it seems.

XML: <fixml:FIXMLencodingType notReqXML="1" />
MD: /P/[fixml:FIXMLencodingType: null]/P/

I do not expect to see "null" or square brackets. Is that intended?

@kleihan
Copy link
Member Author

kleihan commented Sep 6, 2022

Suppress appinfo with purpose "FIXML" unless command line switch "--fixml" to show FIXML content (e.g. abbreviated names) is set.

@donmendelson
Copy link
Member

An explanation for current ouput:

  • The fixml element contents actually consists of 3 XML nodes.
  • Invoking toString() results in a call to a Java library function to output a collection as a string. For each element, it outputs the node contents with type in brackets and any attributes, which in this case are null.

@donmendelson donmendelson added the fixed Issue has been resolved, awaits testing label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Issue has been resolved, awaits testing
Projects
Status: No status
Development

No branches or pull requests

2 participants