-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[md2orchestra] What are the expected values of repository element attributes for name and version? #73
Comments
Current code uses the entire heading to form the repository name; it does not look for a keyword.
It does use the keyword "version" to locate the version token, which is redundant with name and inconsistent with the prototype. |
I edited the issue description. The keyword "Repository" is not required, only a level 1 header. This is also the reason why there can only be one level 1 header in a Tablature markdown file with the current software version. Running Tablature v1.0.1 shows the following actual behavior for the cases in the issue description:
Case 1: unexpected result, to be seen as a convenience. Behavior must change if Tablature is to support multiple level 1 headings (allows to have repository and verbose text in a single markdown file representing an entire Rules of Engagement spec). Cases 3-5: result consistent with @donmendelson's statement on current code but unexpected compared to issue description above. Open: should version information be repeated as part of the name or should the name end as soon as the keyword "version" is encountered? Case 4: result as expected, Tablature requires keyword "version" (case-insensitive) to recognize a version number. |
Suggested md2orchestra algorithm: The processor can look for keywords "repository" and "version". (With md-grammar issue FIXTradingCommunity/md-grammar#9, tokens will be allowed to have an internal space when surrounded by quotes, so a name with a space would be supported.) |
@donmendelson in light of wanting to support multiple level 1 headings, why not do the following? if "repository" is not present, skip content of source file until the next level 1 heading is encountered. That would require |
@kleihan then orchestra2md should always output "repository" token before name. |
Yes, that would be the consequence. But if that is all there is to it then it seems like a low hanging fruit (if we make changes anyway) to achieve the goal of being able to put an entire Rules of Engagement spec into a single markdown file. |
Metadata "title" should also be populated from the repository heading. |
@kleihan If there are other sections at heading level 1 that are not imported into Orchestra, then they would be lost in a round trip. In my view, it would be better to keep "Introduction" at level 2 and import it as documentation about the repository. The Orchestra file would be self-contained. |
Use md-grammar enhancement to allow name with internal space surrounded by quotes
@donmendelson @kleihan Just my 2 cents:
What is the recommended way to take part in this discussion? Via GitHub issues? |
How should the repository information in the markdown file be converted to Orchestra XML attributes? Here are some cases (please add more if needed) and proposed answers for discussion.
# MyRepository
missing completely ==> input file cannot be processed# My Repository
without version ==>name="My Repository" version="1.0"
# My Repository version
without version number ==>name="My Repository" version="1.0"
# My Repository V2.0
==>name="My Repository V2.0" version="1.0"
# My Repository Version 2.0
==>name="My Repository" version="2.0"
The text was updated successfully, but these errors were encountered: