Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1] Contraptions do not produce footsteps #1169

Closed
Sollace opened this issue Oct 22, 2023 · 5 comments
Closed

[1.20.1] Contraptions do not produce footsteps #1169

Sollace opened this issue Oct 22, 2023 · 5 comments
Labels
type: bug Issue where something isn't working type: upstream This is inherited from upstream Forge Create. It is highly unlikely we will change it.

Comments

@Sollace
Copy link

Sollace commented Oct 22, 2023

Describe the Bug

Some backstory:
I was working on implementing a proper solution to generating footsteps when walking on contraptions with Presence Footsteps, but I was unable to get any sounds to play at all.

I had some success with adding a mapping to the blockmap.json to use the existing function, and removing the part that blocks sounds from coming over the network, but for some reason it only worked for other players in multiplayer and only sometimes for yourself, and wouldn't produce steps appropriate to the blocks in the contraption.

I also noticed that footsteps would also not play when PF itself was turned off, so I left it.

Then today I was looking at it again, and after working out a proper solution that integrates with Create directly... It still wouldn't play.

So I decided to just remove PF completely from the environment and test it like that.

Turns out Create's contraptions don't produce footsteps at all even with the mod loaded on its own with nothing besides Create, Mod Menu, and Quilted Fabric API.

Reproduction Steps

The setup I used looks like this:

image

Without really knowing very much, I use a motor, axel, and bearing to rotate some blocks and stomped around on them in creative.

Footsteps work when walking on regular blocks, but nothing plays when walking on the rotated blocks.

Expected Result

Self explanatory

Screenshots and Videos

image

Crash Report or Log

No response

Operating System

Linux

Mod Version

0.5.1d

Minecraft Version

1.20.1

Other Mods

No response

Additional Context

No response

@Sollace Sollace added the type: bug Issue where something isn't working label Oct 22, 2023
Sollace added a commit to Sollace/Presence-Footsteps that referenced this issue Oct 22, 2023
@IThundxr
Copy link
Member

A PR should be made to the forge repo adding footsteps to contraptions. Or a issue if you don't wanna make a PR

@IThundxr IThundxr added the type: upstream This is inherited from upstream Forge Create. It is highly unlikely we will change it. label Feb 14, 2024
@TropheusJ
Copy link
Member

I am pretty sure they used to make sound, which prompted my original issue about compat. Did you check if it's actually broken on forge too?

@IThundxr
Copy link
Member

I am pretty sure they used to make sound, which prompted my original issue about compat. Did you check if it's actually broken on forge too?

Yes its broken on forge aswell, they dont make sounds

@IThundxr
Copy link
Member

Upstream reported at Creators-of-Create#6118

@DarianLStephens
Copy link

DarianLStephens commented Feb 16, 2024

Yeah, this has been an issue since 1.19.
Interestingly, Valkyrien Skies had the exact same thing happen at the same time, a loss of footstep sounds when transitioning to Minecraft 1.19.
My suspicion is that something changed with how Minecraft handles them, and the mods never updated to deal with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working type: upstream This is inherited from upstream Forge Create. It is highly unlikely we will change it.
Projects
None yet
Development

No branches or pull requests

4 participants