Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe for Tea does not match Forge version's #1251

Closed
shimmer-n-shine opened this issue Dec 27, 2023 · 7 comments
Closed

Recipe for Tea does not match Forge version's #1251

shimmer-n-shine opened this issue Dec 27, 2023 · 7 comments
Labels
type: bug Issue where something isn't working

Comments

@shimmer-n-shine
Copy link

shimmer-n-shine commented Dec 27, 2023

Describe the Bug

In the forge version of create, half a bucket of tea is created from a quarter bucket of water and milk (source code), however, in the fabric version of the mod, 1 bottle of milk and water equates to 2 bottles of tea. (source code)

1 bucket of water and milk would produce 1 and a half buckets of tea in forge, but 2 buckets of tea in fabric. EDIT: I did my math wrong so the output for a bucket is the same in both fabric and forge, but still, there's a discrepancy between millibuckets and droplets.

Reproduction Steps

N/A

Expected Result

For fabric and forge to have parity.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

N/A

Mod Version

0.5.1d

Minecraft Version

1.20.1

Other Mods

No response

Additional Context

The issue is present in the code for the 1.18 version as well, I did not check the other branches.

@shimmer-n-shine shimmer-n-shine added the type: bug Issue where something isn't working label Dec 27, 2023
@shimmer-n-shine
Copy link
Author

shimmer-n-shine commented Dec 27, 2023

Also, for the record, the same problem is also present for chocolate (fabric) chocolate (forge) and chocolate melting (fabric) chocolate melting (forge)

@github-actions github-actions bot added the 1.18 label Dec 27, 2023
@drwoops
Copy link

drwoops commented Dec 27, 2023

your math is flawed

@shimmer-n-shine
Copy link
Author

I don't see how 250mb in forge is equal to 27000 droplets in fabric, but okay.

@drwoops
Copy link

drwoops commented Dec 27, 2023

for the forge recipe. if you multiple by 4 the inputs, you also multiply by 4 the output and that comes out as 2 buckets

@shimmer-n-shine
Copy link
Author

I don't know how I missed this, that's completely true, still, the actual issue with a mismatch between mbs and droplets remains

@drwoops
Copy link

drwoops commented Dec 27, 2023

1 mb = 81 droplets. so that comes out as 1 bottle = 1/3 bucket for the fabric recipe. that seems to check out

@TropheusJ
Copy link
Member

This is intended.
Because millibuckets are nonsense, it's both equivalent and not equivalent.
If you go by millibuckets, then on forge, you get 250 + 250 = 500, and on fabric, 333 + 333 = 666.
If you go by bottles, then on both loaders, it's 1 bottle + 1 bottle = 2 bottles.
The bottle method will be kept as it makes much more sense in a fabric environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants