Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering issues with 'Regions Unexplored' plants. #1259

Closed
HaXrDEV opened this issue Jan 3, 2024 · 17 comments
Closed

Rendering issues with 'Regions Unexplored' plants. #1259

HaXrDEV opened this issue Jan 3, 2024 · 17 comments
Labels
type: bug Issue where something isn't working

Comments

@HaXrDEV
Copy link

HaXrDEV commented Jan 3, 2024

Describe the Bug

With only 'Create Fabric' and 'Regions Unexplored' installed, all the grass and plants from the other mod renders darker than they are supposed to.

Also, setting the Flywheel backend to "off" doesn't solve the issue.

Reproduction Steps

  1. Install both 'Create Fabric' and 'Regions Unexplored'.
  2. Notice the modded medium grass texture being darker than vanilla grass.
  3. Remove 'Create Fabric'.
  4. Notice the medium grass texture now being the same brightness as vanilla grass.

Expected Result

The two grass variants should be the same brightness.

Screenshots and Videos

With 'Create Fabric':
2024-01-03_13 43 33

Without 'Create Fabric':
2024-01-03_13 52 38

Crash Report or Log

N/A

Operating System

Windows 11

Mod Version

0.5.1d

Minecraft Version

1.20.1

Other Mods

Regions Unexplored
TerraBlender

Additional Context

This issue applies to all plants from the mod like grass, flowers and saplings.

@HaXrDEV HaXrDEV added the type: bug Issue where something isn't working label Jan 3, 2024
@drwoops
Copy link

drwoops commented Jan 3, 2024

please crash your game by holding F3+C for 10s and attach the crash report

@HaXrDEV
Copy link
Author

HaXrDEV commented Jan 3, 2024

please crash your game by holding F3+C for 10s and attach the crash report

Here ya go: https://gist.github.com/HaXrBOT/2c1f73533388eb519572157deaa47441

@drwoops
Copy link

drwoops commented Jan 3, 2024

downgrade fabric api to 0.88.1

@HaXrDEV
Copy link
Author

HaXrDEV commented Jan 3, 2024

downgrade fabric api to 0.88.1

Tried that, same issue. https://gist.github.com/HaXrBOT/21d981b2cfefcce0a665ed041b870d29

@drwoops
Copy link

drwoops commented Jan 3, 2024

could you try adding indium 1.0.21?

@HaXrDEV
Copy link
Author

HaXrDEV commented Jan 3, 2024

could you try adding indium 1.0.21?

Same issue. https://gist.github.com/HaXrBOT/d3622e899d9ee0c9262b0226d647e507
Note that i am not using Sodium in these tests. So Indium in this case would not be doing anything.

@drwoops
Copy link

drwoops commented Jan 3, 2024

oh you're right.

@drwoops
Copy link

drwoops commented Jan 3, 2024

i wonder if the same issue happens on forge.

@HaXrDEV
Copy link
Author

HaXrDEV commented Jan 3, 2024

i wonder if the same issue happens on forge.

Just tried it for the heck of it. The issue doesn't seem to occur on forge.

billede

@drwoops
Copy link

drwoops commented Jan 3, 2024

did you try it with patch d (for exact parity)?

@HaXrDEV
Copy link
Author

HaXrDEV commented Jan 3, 2024

did you try it with patch d (for exact parity)?

I did not, will try that quickly.

@HaXrDEV
Copy link
Author

HaXrDEV commented Jan 3, 2024

Nope, same thing. Doesn't seem to be happening even with patch d on forge.

2024-01-03_14 37 42

@drwoops
Copy link

drwoops commented Jan 3, 2024

ok. thank you for doing all this testing. that's about as good as we can narrow it down for now.

@drwoops
Copy link

drwoops commented Jan 3, 2024

you could also try to switch between different flywheel backends (off, instancing, batching)

@HaXrDEV
Copy link
Author

HaXrDEV commented Jan 3, 2024

you could also try to switch between different flywheel backends (off, instancing, batching)

Did already try that, it made no difference when i tested on Fabric. Regardless of it being set to off, instancing or batching.

@TropheusJ
Copy link
Member

incredibly strange, genuinely no clue where to even start looking for a fix

@TropheusJ
Copy link
Member

porting lib was overriding the render material since the models specify a render_type. This would be fine, but it was doing it incorrectly. This will be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants