After removing items from moving contraption by shift-clicking, the contraption cannot be disassembled properly and could duplicated

[RanolP]

Describe the Bug

Extract an item from a moving contraption assembled by shift-clicking, and disassemble the contraption. It crashes (or logs an error) with the message java.lang.IllegalArgumentException: Transfer variant may not be blank..

Reproduction Steps

1. Construct any moving contraption with an attached chest containing some items (maybe reproducible with other storage blocks e.g. barrel) - I had reproduced w/ windmill (not crashes, but could lead to dupe bug in Singleplayer), minecart (crashes, see the comment from Server crashes and dupe cart resources #1211 (comment) for vids), gantry (crashes)
2. Remove item from the inventory by shift-clicking
3. Disassemble the contraption

Expected Result

It should be disassembled properly

Screenshots and Videos

output.webm

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

0.5.1d

Minecraft Version

1.20.1

Other Mods

• EMI 1.0.9
• Trinkets 3.7.0
• ModMenu 7.1.0

Additional Context

Related Issues

• Fabric server crashing when disassembly contraption #1080 (and issues marked as duplicates)
  • Server crash when drills on rope pulley descend and hit something that stops them #1208
  • Some blocks disappear after disassembling the train #1134 - Discovered most of the reason, see Some blocks disappear after disassembling the train #1134 (comment)
  • Server crashes and dupe cart resources #1211

Possible Solutions

• I have locally fixed the issue by copying the return value (L102) of StorageInteractionContainer.getItem in my dev env. It seems that the shift-click interaction modifies the return value of getItem directly. But I have no idea if the solution could produce other side effects.
  

  Create/src/main/java/com/simibubi/create/content/contraptions/MountedStorageInteraction.java

  Lines 96 to 103 in 49cc17e

  	@Override
  	public ItemStack getItem(int slot) {
  	if (oob(slot))
  	return ItemStack.EMPTY;
  	ItemStackHandler handler = handlerForSlot(slot);
  	slot = actualSlot(slot);
  	return handler.getStackInSlot(slot);
  	}

• Another possible solution is changing the Porting-Lib code. Apply the isEmpty filter whenever ItemStackHandler.nonEmptyViews is called.
  https://github.com/Fabricators-of-Create/Porting-Lib/blob/41c9aacb30f43e0993c63f1da4438e1943fc6697/transfer/src/main/java/io/github/fabricators_of_create/porting_lib/transfer/item/ItemStackHandler.java#L101-L111

[ergo3983]

I've had this one too, with gantries.
It seems removing a stack (through shift clicking or not) of a moving contraption causes it.

[TropheusJ]

duplicate of #1080