-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
READ_ENUMS_USING_TO_STRING doesn't support null values #2309
Comments
pull request for the fix is here: |
issue posted to facebook-java-business-sdk as well: |
But is it even legal to return I guess I could instead throw an exception to indicate bad return value. I am not sure I'm comfortable coercing |
@cowtowncoder - any word on this? I'm not saying my solution is the best/most correct, but can you introduce a way to make the failing test (that I demonstrate) work? |
@andersonbd1 I haven't had time to look but I'll add this to my todo list for another glance. Thank you for reminder. |
Thanks @cowtowncoder . I just got a reply from facebook here - facebook/facebook-java-business-sdk#235 (comment) Sounds like they're more concerned about supporting gson. |
@andersonbd1 that makes sense wrt Facebook, they don't really need to worry about json handling performance. :) But regardless I am interested in Jackson side of things. |
The test added in EnumDeserializationTest.java fails w/out the fix in EnumResolver.java.
https://github.com/FasterXML/jackson-databind/pull/2307/files
The text was updated successfully, but these errors were encountered: