Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change JsonNode.withObject(String) to work similar to withArray() wrt argument #4096

Closed
cowtowncoder opened this issue Aug 22, 2023 · 0 comments
Closed

Change JsonNode.withObject(String) to work similar to withArray() wrt argument #4096

cowtowncoder opened this issue Aug 22, 2023 · 0 comments
Labels
2.16 Issues planned for 2.16

Comments

@cowtowncoder
Copy link
Member

Describe your Issue

(see #3780 for lengthy background discussion)

New JsonNode.withObject(String) method added in 2.14 only allows for using String that is valid JsonPointer expression. This is different from existing withArray(String) method. While I earlier felt that the new behavior is more sensible, avoiding confusion, it seems many users feel otherwise.

As a consequence I think behavior should be changed for 2.16 to allow for "property-or-expression" -- this should be safe (enough) change and along with #4095 solve the issue.
@cowtowncoder cowtowncoder added the to-evaluate Issue that has been received but not yet evaluated label Aug 22, 2023
@cowtowncoder cowtowncoder mentioned this issue Aug 22, 2023
Closed
@cowtowncoder cowtowncoder mentioned this issue Sep 30, 2023
Merged
@cowtowncoder cowtowncoder added 2.16 Issues planned for 2.16 and removed to-evaluate Issue that has been received but not yet evaluated labels Sep 30, 2023
cowtowncoder added a commit that referenced this issue Sep 30, 2023
@cowtowncoder
Fix #4096: change JsonNode.withObject(String) to accept non-express…
d31412a 
…ion as property name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.16 Issues planned for 2.16
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cowtowncoder