Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable forc fmt to operate on the LSP tmp files so it can format unsaved changes. #6787

Open
JoshuaBatty opened this issue Dec 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working formatter language server LSP server

Comments

@JoshuaBatty
Copy link
Member

There has been a few reports on Slack where people are running into problems with the lsp_lock files disabling the ability to run forc fmt

from Cam

I'm still getting this error every once in a while. The solution has been to delete .forc/.lsp-locks/. I think it has to do with the fact that I have multiple instances of VSCode open across multiple repos i.e. sway, sway-standards, sway-libs, my test projects, etc. I haven't found a consistent way to reproduce it.

from Swayam

I only have one vscode open so I don't think there being multiple is the problem

Screenshot 2024-12-11 at 12 53 45

If we just consider the following scenario. A user is editing a file in vscode with unsaved changes. They then run forc fmt in the in built terminal. This will produce the error above. This is because forc fmt is only operating from the saved file on disk which contains the unsaved changes.

One idea is instead of just locking this operation, we could use the file saved in .forc/.lsp-locks/ to contain the path to the file in tmp. This way, forc fmt could then get access to the unsaved changes and still run formatting on the file that lsp is operating on. This would remove the need for locking the forc fmt process.

@JoshuaBatty JoshuaBatty added bug Something isn't working language server LSP server formatter labels Dec 12, 2024
@JoshuaBatty JoshuaBatty self-assigned this Dec 12, 2024
@JoshuaBatty
Copy link
Member Author

Just leaving a note for myself to also handle how the new forc-migrate tool uses the lock file #6790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working formatter language server LSP server
Projects
None yet
Development

No branches or pull requests

1 participant