Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for systems where linking to atomic is required #2718

Open
nightlark opened this issue Dec 27, 2024 · 0 comments
Open

Add checks for systems where linking to atomic is required #2718

nightlark opened this issue Dec 27, 2024 · 0 comments
Labels
bug Issue concerning incorrect code operation

Comments

@nightlark
Copy link
Member

For getting the Yggdrasil package updated to 3.6 (#2716), a patch to link against -latomic on some platforms was needed -- specifically they've added riscv64 binaries to the build matrix for Yggdrasil, and there were undefined reference errors to __atomic_compare_exchange_1, __atomic_fetch_or_2, __atomic_fetch_and_2, __atomic_compare_exchange_2, __atomic_fetch_add_2, and __atomic_fetch_sub_2.

Ideally I think we'd use some combination of https://cmake.org/cmake/help/latest/module/CheckLibraryExists.html and https://cmake.org/cmake/help/latest/module/CheckSourceCompiles.html#module:CheckSourceCompiles -- and this would also remove the need for the PI specific build configuration option.

@nightlark nightlark added the bug Issue concerning incorrect code operation label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue concerning incorrect code operation
Projects
None yet
Development

No branches or pull requests

1 participant