diff --git a/.gitmodules b/.gitmodules new file mode 100644 index 00000000..dca6cdb4 --- /dev/null +++ b/.gitmodules @@ -0,0 +1,3 @@ +[submodule "hipbin"] + path = hipbin + url = https://github.com/GPUOpen-LibrariesAndSDKs/RadeonProRenderSDKKernels diff --git a/hipbin b/hipbin new file mode 160000 index 00000000..a222c3e8 --- /dev/null +++ b/hipbin @@ -0,0 +1 @@ +Subproject commit a222c3e88c5e26c9b7b7858121f7be7775bb1afb diff --git a/readme.md b/readme.md index 7011baf2..33b9ff12 100644 --- a/readme.md +++ b/readme.md @@ -16,14 +16,11 @@ This repo contains : ## Install Precompiled Kernels Since 3.01.00, for Northstar the default render backend is HIP ( instead of OpenCL ). \ -The main difference is that compute kernels are now precompiled by us. They must be downloaded from a separate link.\ +The main difference is that compute kernels are now precompiled by us. They must be downloaded from a submodule.\ Note that for now you can still use the OpenCL backend ( with `RPR_CREATION_FLAGS_ENABLE_OPENCL` in `rprCreateContext` ). However we don't recommend it as in the future we may put less resource to support this backend.\ -Download the precompiled kernels here: https://www.dropbox.com/s/uojh957rxcvrc6b/hipbin_3.01.00.zip?dl=0 \ -In order to run tutorials, it's recommended to put the package inside tutorials/Bin/ so that it looks like that: +Download the precompiled kernels with the command: ``` -tutorials/Bin/hipbin/AllPreCompilations.json -tutorials/Bin/hipbin/****.hipbin -tutorials/Bin/hipbin/****.cudabin +git submodule update --init --recursive ``` The precompiled kernels folder can be modified with `RPR_CONTEXT_PRECOMPILED_BINARY_PATH`. ( for its usage, check the tutorials ). diff --git a/tutorials/common/common.h b/tutorials/common/common.h index fcb5e505..90c84208 100644 --- a/tutorials/common/common.h +++ b/tutorials/common/common.h @@ -63,10 +63,10 @@ const rpr_context_properties g_contextProperties[] = { // define the precompiled kernels folder. - // for most of the tutorials, the path will be /hipbin/*****.hipbin + // for most of the tutorials, the path will be ../../hipbin/*****.hipbin // ( check the readme for more information about precompiled kernels ) (rpr_context_properties)RPR_CONTEXT_PRECOMPILED_BINARY_PATH, - (rpr_context_properties)"hipbin", + (rpr_context_properties)"../../hipbin", // terminate the list of properties with a NULL (rpr_context_properties)0,