Skip to content
This repository has been archived by the owner on Jul 8, 2020. It is now read-only.

lighthouse bot succeeds even when minimum required threshold is not met #62

Closed
RVledder opened this issue May 14, 2019 · 3 comments · Fixed by #69
Closed

lighthouse bot succeeds even when minimum required threshold is not met #62

RVledder opened this issue May 14, 2019 · 3 comments · Fixed by #69

Comments

@RVledder
Copy link

See the output table on: RVledder/spindle.wtf#7 (comment)

The settings in Travis are set like this: https://github.com/StudioSpindle/spindle.wtf/blob/develop/.travis.yml

Is this a bug or is it a setting that is wrong?

@erezrokah
Copy link

@StudioSpindle I had a similar issue. I found out it takes some time until the lighthousebot account responds to the invitation to collaborate.

You can check this here:
image

@EoinTraynor
Copy link
Contributor

Until Lighthouse accepts the invitation to collaborate it does not have permission to fail a check.
However, it will post a comment on your PR.
Here is the original issue Issue 8

@erezrokah How long did you have to wait for acceptance? I requested collaboration 6 days ago.

@erezrokah
Copy link

@EoinTraynor I don't remember exactly. I think a couple of hours

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants