Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support importing Taskwarrior v2.x data files #3724

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

djmitche
Copy link
Collaborator

This should ease the pain of upgrading from v2.x to v3.x.

The TF2.{h,cpp} are copied from 2.6.2's TDB2.{h,cpp}, slimmed down to support only the most recent file format (which I believe was introduced somewhere in the 2.5.x series?) and only reading, not writing.

Once this lands, I'll update the importing instructions in tw.org.

Fixes #3720.

This should ease the pain of upgrading from v2.x to v3.x.
@djmitche djmitche requested a review from felixschurk December 15, 2024 23:46
Copy link
Collaborator

@felixschurk felixschurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

Where there any unit test for this format? I skimmed the repo and did not find any. If there are none I think we are good to go, otherwise we can also add them back again.

@djmitche
Copy link
Collaborator Author

Yeah, I don't see any tests from the old version, but it's easy enough to add one.

@djmitche djmitche enabled auto-merge (squash) December 17, 2024 01:15
@djmitche djmitche merged commit cc505e4 into GothenburgBitFactory:develop Dec 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support automatically importing 2.x tasks
2 participants