Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybooks shouldn't be part of build #22

Open
atherdon opened this issue Feb 27, 2019 · 2 comments
Open

storybooks shouldn't be part of build #22

atherdon opened this issue Feb 27, 2019 · 2 comments

Comments

@atherdon
Copy link
Member

No description provided.

@kaiz123
Copy link
Contributor

kaiz123 commented Feb 27, 2019

The storybook files would never be imported anywhere and would thus not be part of the dependency graph that webpack creates. Thus, there is no need for any further elimination.

@atherdon
Copy link
Member Author

it's debatable. You are right, but only because of this lines: https://github.com/GroceriStar/antd-showcase-components/blob/master/package.json#L67-L69
without this rules - it might be part of build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants