Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with Japanese Support #43

Closed
rockmor opened this issue Nov 19, 2023 · 3 comments
Closed

Conflict with Japanese Support #43

rockmor opened this issue Nov 19, 2023 · 3 comments

Comments

@rockmor
Copy link

rockmor commented Nov 19, 2023

Describe the bug
Something in this addon seem be in conflict with both Japanese Support and AJT Japanese addons (both of which create auto generated readings same as Chinese Support).
Basically, neither Japanese Support nor AJT Japanese generate any readings when Chinese Support is active. When I disable Chinese Support, the problem goes away.
This wasn't the case in previous versions of Anki or Chinese Support.
I think the problem is caused by Chinese Support, because it affects both of Japanese addons. Though, I can be wrong.

Also, if I toggle the 汉字 button, the Japanese readings are generated (they are even correct), but the format is wrong.

Steps to reproduce the behavior:

  1. Install Chinese Support and either Japanese Support or AJT Japanese (or both).
  2. Try to add a card to the Japanese deck (in case of AJT Japanese be sure that the field names in Settings are correct, in my case it's "Expression" and "Reading") with 汉字 button toggled off.
  3. Try to add a card to the Japanese deck with 汉字 button toggled on.
  4. Uninstall (or toggle off) Chinese Support and try to add a card to the Japanese deck.

Expected behavior
Reading is generated after hitting TAB.
The 汉字 button shouldn't affect the behavior of Japanese addons.

изображение
汉字 button off

изображение
汉字 button on

изображение
How the generated line looks (it should be furigana above the word)

Specs (please complete the following information):

  • OS: Windows
  • Anki Version: 23.10.1
  • Chinese Support Version: 0.16.0
@kieranlblack
Copy link
Contributor

Thanks for the bug report. I believe this was fixed as a byproduct of #30. The fix should be live in the next version, although I'm not sure when @Gustaf-C plans on cutting that release.

@Gustaf-C
Copy link
Owner

I just pushed the newest version, please check if the issue remains.

@rockmor
Copy link
Author

rockmor commented Nov 20, 2023

@Gustaf-C
The problem is gone. Thank you a lot!

@rockmor rockmor closed this as completed Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants