-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material social cards not working with customized social.cards_dir directory #319
Comments
It also doesn't seem to be using the computed location correctly when used with the material blog plugin: squidfunk/mkdocs-material#7518 If it helps, here's how mkdocs-material references the |
Hello @jonaharagon and @perpil, Sorry for the delay, I work on this side-project from time to time, mainly when I have free time to develop, review, get paid for or have a particular need. Which version of the plugin are you using? Because since 1.16, the integration with Material Blog has been improved: https://guts.github.io/mkdocs-rss-plugin/changelog/#1160---2024-10-24 Since you're using the Material theme, please consider using the same report workflow as described in their documentation: https://squidfunk.github.io/mkdocs-material/contributing/reporting-a-bug/ |
Thanks for the update! Using 1.17, the repro that was attached to squidfunk/mkdocs-material#7518 seems to be working. However, when I try with my |
Ok, here's a repro. It appears to be that the build directory for social cards isn't correct when 9.5.48+insiders.4.53.14-rss-social-use_directory_urls-false.zip I was able to make some minor edits to the code to make it work in this scenario, will see if I can make it work for all scenarios. |
Thanks @perpil for your attentive tests and following up here, really appreciated. I try to have a look before next year! |
assets/images/social
is hardcoded at this line, so if you change the directory where social cards are stored then the cards are not detected and linked to properly:mkdocs-rss-plugin/mkdocs_rss_plugin/integrations/theme_material_social_plugin.py
Line 309 in 19069bb
For example this configuration would be broken:
The text was updated successfully, but these errors were encountered: