enabling vertical fishing

[thomas992]

I was watching this youtube video, go to the 6 minute mark
https://www.youtube.com/watch?v=bQZxws90FP0

line 658 z_fishing.c
        thisx->focus.pos = thisx->world.pos;
        thisx->focus.pos.y += 75.0f;

I think this is the relevant area which ignores the Z value. I think the fix would be to encapsulate a min and a max function along with a postive 75 iteration but I might not even be looking at the right function

[thomas992]

I think it should be 50 towards Link (slightly slower than horizontal) so focus.pos.z = (focusposz > worldposz) ? focusposz : math.min(focusposz + 50, worldposz) something like that? It just occurred to me that we would be increasing the total speed which is unintended, perhaps it should be so if there is vertical distance, to make the total speed 75.

[thomas992]

line 3625 z_fishing.c
Math_ApproachS(&player->actor.shape.rot.y, this->actor.yawTowardsPlayer + 0x8000, 5, 0x500);

I spent some time naming variables and I think I found the real culprit, this is a PR for the labeling I did it might help people implement the fix
#1269

[aMannus]

I'm not really sure why this should be added to SoH. Maybe as a mod if someone really wants to play around with it, but outside of spawning the fishing actor in random places, this doesn't really have a use.

[g-l-i-t-c-h-o-r-s-e]

nice work labeling stuff, it'll make future fishing mods easier to do :>
I'm currently working on trying to get the AI to spawn more consistently, instead of swimming to the center of the map at 0,0,0

But i'll take a look at what you're trying to do too. One thing I've noticed is as long as you're near the edge of a raised platform while fishing, it will normally warp the fish up to you