create new GI_SWORD_RANDO_BGS with new text ids (or just add custom message logic)

[briaguya-ai]

GI_SWORD_BGS has some fancy text id logic based on having the giant's knife or not (not sure where that's hiding)

this logic is causing some oddities when getting the BGS from shops/chu bowling (showing both text boxes)

the text in those already doesn't make too much sense in the context of rando (you handed in the claim check/you traded the giant's knife), so it probably makes sense to just make a new item for BGS in rando with more generic text

this text could be

You got the Biggoron's Sword!
This blade was forged by a
master smith and won't break!

(we'll need some translations for it)

in order to make this change, we'll need to look through the codebase for anywhere rando is looking for GI_SWORD_BGS and replace it with the new id (and test everything works as expected)

[briaguya-ai]

another possible option, skip making the new item and just add some custom logic in

Shipwright/soh/src/code/z_message_PAL.c

Lines 1698 to 1699 in 219dec9

	} else if (msgCtx->textId == 0xC && CHECK_OWNED_EQUIP(EQUIP_SWORD, 2)) {
	textId = 0xB; // Traded Giant's Knife for Biggoron Sword

something like

if (gSaveContext.n64ddFlag && (msgCtx->textId == 0xC || msgCtx->textId == 0xB) {
  textId = //either just set it to 0C or use a new message id without the you traded stuff
}

[briaguya-ai]

moved to v3 because we have a good v2 short term fix for the softlock issue, no need to rush this