Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroic shows bought UE Marketplace/Fab assets in the games library #4200

Open
BSoD38 opened this issue Dec 24, 2024 · 3 comments
Open

Heroic shows bought UE Marketplace/Fab assets in the games library #4200

BSoD38 opened this issue Dec 24, 2024 · 3 comments
Labels
bug:unconfirmed Someone works on identifying the issue

Comments

@BSoD38
Copy link

BSoD38 commented Dec 24, 2024

Describe the bug

The Heroic games library displays the UE assets I have acquired on Fab (previously UE Marketplace), when I think it shouldn't. These assets have no logo and show the default Heroic logo.

Perhaps these items should be hidden by default.

Add logs

Heroic: https://0x0.st/8r4y.log
Epic: https://0x0.st/8r4t.log

Steps to reproduce

  1. Go on Fab and grab some free assets (preferably UE assets, I don't know if other assets types will trigger the issue)
  2. Open Heroic and go to your library
  3. You will find your Fab assets among your games

Expected behavior

Fab assets are not visible (at least not by default), perhaps add a filter so you can display them if you want to.

Screenshots

image

Heroic Version

Latest Stable

System Information

  • OS [e. g. "Ubuntu"]: Windows 11

Additional information

No response

@BSoD38 BSoD38 added the bug:unconfirmed Someone works on identifying the issue label Dec 24, 2024
@arielj
Copy link
Collaborator

arielj commented Dec 24, 2024

can you search for the metadata of one of those assets? it should be in C:\Users\BSoD\AppData\Roaming\heroic\legendaryConfig\legendary\metadata I think

that can help us identify what information we can use to hide them

@BSoD38
Copy link
Author

BSoD38 commented Dec 24, 2024

Sure, here's one from Platform Functions:

{
  "app_name": "PlatformFunctionsPlugin_5.4",
  "app_title": "Platform Functions",
  "asset_infos": {},
  "base_urls": [],
  "metadata": {
    "ageGatings": {},
    "applicationId": "",
    "categories": [
      {
        "path": "plugins/engine"
      },
      {
        "path": "plugins"
      },
      {
        "path": "asset-format/game-engine"
      },
      {
        "path": "type/format-item"
      },
      {
        "path": "asset-format/game-engine/unreal-engine"
      },
      {
        "path": "type"
      },
      {
        "path": "asset-format"
      }
    ],
    "creationDate": "2024-09-18T11:12:40.201Z",
    "customAttributes": {
      "ListingIdentifier": {
        "type": "STRING",
        "value": "f84001ab-0aed-4a8f-b976-7203fadc338a"
      }
    },
    "description": "Platform Functions",
    "developer": "GalacticGames.com",
    "developerId": "o-5bxgyksrlkrv8uc8llt449rz9nxhvs",
    "endOfSupport": false,
    "entitlementName": "f6ea0709bea0432982eaecb2b455395f",
    "entitlementType": "AUDIENCE",
    "eulaIds": [],
    "id": "f6ea0709bea0432982eaecb2b455395f",
    "itemType": "DURABLE",
    "keyImages": [],
    "lastModifiedDate": "2024-10-25T22:45:57.401Z",
    "namespace": "89efe5924d3d467c839449ab6ab52e7f",
    "releaseInfo": [
      {
        "appId": "PlatformFunctionsPlugin_5.2",
        "compatibleApps": [
          "UE_5.2"
        ],
        "dateAdded": "2024-09-18T18:08:01.379Z",
        "id": "296d98ce7ca745ccb3c7c3c11fde620c",
        "platform": [
          "Windows",
          "Win32",
          "Linux",
          "Mac"
        ],
        "versionTitle": "2.4"
      },
      {
        "appId": "PlatformFunctionsPlugin_5.3",
        "compatibleApps": [
          "UE_5.3"
        ],
        "dateAdded": "2024-09-18T18:08:00.000Z",
        "id": "49b857daa2bb456a9a3b02cd0305b99e",
        "platform": [
          "Windows",
          "Mac",
          "Linux",
          "Win32"
        ],
        "releaseNote": "Project File Password: EpicIsAwsome123!",
        "versionTitle": "v2.4_5.3"
      },
      {
        "appId": "PlatformFunctionsPlugin_5.4",
        "compatibleApps": [
          "UE_5.4"
        ],
        "dateAdded": "2024-09-18T18:08:00.000Z",
        "id": "1887df010a9246bbbb9a901173642b58",
        "platform": [
          "Windows",
          "Mac",
          "Linux",
          "Win32"
        ],
        "releaseNote": "Project File Password: EpicIsAwsome123!",
        "versionTitle": "v2.4_5.4"
      }
    ],
    "requiresSecureAccount": false,
    "status": "ACTIVE",
    "title": "Platform Functions",
    "unsearchable": false
  },
  "sidecar": null
}

@arielj
Copy link
Collaborator

arielj commented Dec 24, 2024

Looks like this was already addressed by https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/pull/4133/files

it will be included in the next release of heroic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:unconfirmed Someone works on identifying the issue
Projects
None yet
Development

No branches or pull requests

2 participants