Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu to search results for better file navigation #876

Open
jelveh opened this issue Nov 20, 2024 · 8 comments
Open

Add context menu to search results for better file navigation #876

jelveh opened this issue Nov 20, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jelveh
Copy link
Contributor

jelveh commented Nov 20, 2024

Currently, search results are displayed as a simple list without additional interaction options other than being opened when clicked. To improve user experience and file navigation, we should add a context menu to search result items.

Screenshot 2024-11-19 at 5 59 43 PM

Feature Requirements:

  1. Implement a context menu using the existing UIContextMenu
  2. The context menu should appear on right-click of any search result item
  3. Include two primary actions:
    • Open File (can also be triggered by left-clicking the item)
    • Open Containing Folder (reveals the file's location in File Explorer)

Technical Notes:

  • Use the existing UIContextMenu component for consistency with the rest of the UI
  • The "Open File" action can reuse the same functionality as clicking the item
  • The "Open Containing Folder" action should:
    • Navigate to the parent directory of the file
    • Optionally highlight/select the file in its containing folder
    • You will need to use the UIWindow component for this:
       UIWindow({
            path: [ITEM PATH],
            title: path.basename([ITEM PATH]),
            icon: await item_icon({is_dir: true, path: [ITEM PATH]}),
            uid: [ITEM UID],
            is_dir: [IS DIR?],
            app: 'explorer',
        });```
@jelveh jelveh added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 20, 2024
@gamersprogrammer
Copy link

Hey, I would like to be assigned this issue

@jelveh
Copy link
Contributor Author

jelveh commented Nov 29, 2024

Hi @gamersprogrammer, assigned! Let me know if you need any help.

@gamersprogrammer
Copy link

Hi @gamersprogrammer, assigned! Let me know if you need any help.

I keep getting run error.

@Krits-devops
Copy link

Hey, I would love to work on this issue as well.

@mariatouil
Copy link
Contributor

Hello, I have just fixed this issue. Could you please assign it to me?

@jelveh
Copy link
Contributor Author

jelveh commented Dec 6, 2024

@mariatouil could you submit a PR for it?

@mariatouil
Copy link
Contributor

ok thank you

@mariatouil
Copy link
Contributor

mariatouil commented Dec 16, 2024

@jelveh Hi,
I’ve submitted a Pull Request to address this issue: #1049.
Could you please review it and let me know if everything looks good?

Thank you in advance for your feedback!

mariatouil added a commit to mariatouil/puter that referenced this issue Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants