Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to cancel ongoing deployments in Dev Center #879

Open
jelveh opened this issue Nov 20, 2024 · 9 comments
Open

Add ability to cancel ongoing deployments in Dev Center #879

jelveh opened this issue Nov 20, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jelveh
Copy link
Contributor

jelveh commented Nov 20, 2024

Currently, once a deployment starts in Dev Center, users have no way to cancel it even if they realize they selected the wrong files or the deployment is taking too long. This can be frustrating, especially with large deployments.

All the relevant code resides in dev-center.js

Technical Requirements:

  1. Add a cancel button to the deployment progress interface:

    • Replace or augment the current "Deploying (X%)" message with a cancellable interface
    • Add a clear visual indicator that the deployment can be cancelled (e.g., "✕" button)
  2. Implement proper cancellation handling:

    • Cancel any ongoing file uploads/transfers
    • Clean up any partially uploaded files in the app directory
    • Reset the drop area to its initial state
    • Show feedback that the deployment was cancelled
  3. Consider states where cancellation might not be possible:

    • If deployment is near completion
    • During critical operations that shouldn't be interrupted
    • Add appropriate UI feedback for such cases

User Experience Flow:

  1. User starts deployment
  2. During "Deploying (X%)", user can click cancel
  3. Show brief "Cancelling..." message
  4. Clean up partial deployment
  5. Reset UI to pre-deployment state

Expected Behavior:

  • The cancel button should be clearly visible during deployment
  • Cancellation should be responsive and immediate
  • User should receive clear feedback about the cancellation
  • The app should return to a clean state after cancellation
@jelveh jelveh added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 20, 2024
@mariatouil
Copy link
Contributor

Hey, I would like to fix this issue. Can you assign it to me, please?

@jelveh
Copy link
Contributor Author

jelveh commented Nov 28, 2024

Hi @mariatouil. I just assigned this issue to you. Let me know if you need any help.

@gamersprogrammer
Copy link

Hey, I would like to assist @mariatouil on it

@jelveh
Copy link
Contributor Author

jelveh commented Nov 29, 2024

@mariatouil if you need help on this issue @gamersprogrammer might be able to lend you a hand.

@HatemLamia
Copy link
Contributor

Hey, I'm Maria's partner, and we're working on this issue together.

@HatemLamia
Copy link
Contributor

Hey, to work on this issue, do I need another file or code apart from the Dev Center?

@jelveh
Copy link
Contributor Author

jelveh commented Dec 5, 2024

@HatemLamia, not really. All the code for deployment is in Dev Center.

@HatemLamia
Copy link
Contributor

Alright, thank you! I've just added the button and will ensure the code is pushed as soon as possible.
imagecancel

@HatemLamia
Copy link
Contributor

Hi @jelveh,
I’ve submitted a Pull Request to address this issue: #1074 .
Could you please review it and let me know if everything looks good?
Thank you in advance for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants