Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacktoberfest #24943

Closed
reitermarkus opened this issue Sep 28, 2016 · 14 comments
Closed

Hacktoberfest #24943

reitermarkus opened this issue Sep 28, 2016 · 14 comments

Comments

@reitermarkus
Copy link
Member

reitermarkus commented Sep 28, 2016

Welcome to Hacktoberfest!

If you've never made a Pull Request before, Homebrew Cask is a great place to start! We provide an easy way to manage GUI apps (known as Casks) on macOS.

Check out CONTRIBUTING for help with common tasks (adding a new Cask, updating an existing Cask, etc.)


We appreciate every contribution, but here's a list of some issues you could help us out with (curated from the list of issues):

@vitorgalvao
Copy link
Member

None. @adidalal mentioned this earlier today on Gitter. Deprecate license: seems like a good candidate, as do most ready to implement.

@vitorgalvao
Copy link
Member

Made the label, with their button color.

@reitermarkus
Copy link
Member Author

Updated my top post to serve as a pointer.

@Saklad5
Copy link
Contributor

Saklad5 commented Sep 29, 2016

Wait, we aren’t supposed to be using the license stanza anymore?

@Saklad5
Copy link
Contributor

Saklad5 commented Sep 29, 2016

I’m tackling 3MCloudLibrary now, by the way.

@vitorgalvao
Copy link
Member

Wait, we aren’t supposed to be using the license stanza anymore?

We still need to use it (the code isn’t yet deprecated), but the stanza itself doesn’t matter anymore (it never did, in practice).

@Saklad5
Copy link
Contributor

Saklad5 commented Sep 29, 2016

So I should basically just leave “unknown" there until it is finally deprecated?

@vitorgalvao
Copy link
Member

So I basically I should just leave "unknown" there until it is finally deprecated?

Whatever you want. If you want to make it more correct than unknown, no harm done, but it won’t matter in the future.

@ncovercash
Copy link

ncovercash commented Oct 7, 2016

I am trying to make my first cask, but it isn't working

I'm using the following:

cask 'hwsensors' do
  version '6.21.1412'
  sha256 'b4ccef946849811069b0beb68a4c278b526a79d8dd8caa25415bad5042600fdc'

  # On GitHub at https://github.com/kozlek/HWSensors but pkg not updated on minor releases
  url "http://www.hwsensors.com/content/01-releases/42-release-1412/HWSensors.#{version}.pkg"
  # Inconcistent naming scheme - follows 01-releases/{number update}-release-{minor version}.pkg
  # Filed GH issue for it: https://github.com/kozlek/HWSensors/issues/341
  name 'HWSensors'
  homepage 'http://www.hwsensors.com/'
  license :gpl

  pkg 'HWSensors.#{version}.pkg'

  uninstall pkgutil: 'org.hwsensors.HWMonitor'
end

However, it is looking in the wrong directory:

==> Downloading http://www.hwsensors.com/content/01-releases/42-release-1412/HWSensors.6.21.1412.pkg
Already downloaded: /Users/noah/Library/Caches/Homebrew/Cask/hwsensors--6.21.1412.pkg
==> Verifying checksum for Cask hwsensors
==> Running installer for hwsensors; your password may be necessary.
==> Package installers may write to any location; options such as --appdir are ignored.
Error: pkg source file not found: '/usr/local/Caskroom/hwsensors/6.21.1412/hwsensors--6.21.1412.pkg'

I have tried using

  • hwsensors--6.21.1412.pkg
  • HWSensors.#{version}.pkg
  • hwsensors--#{version}.pkg
  • HWSensors--6.21.1412.pkg
    but none work

@vitorgalvao
Copy link
Member

@smileytechguy Try adding container type: :naked. If it does not solve it, please open a new issue, lets not mix conversations. You’ll also need to remove the comments from the cask.

@reitermarkus
Copy link
Member Author

Closing this, since Hacktoberfest sadly has come to an end. Thanks to all contributors, we “won”! 😂

@vitorgalvao
Copy link
Member

@reitermarkus Where did you find those statistics? Is there any more interesting information?

@Saklad5
Copy link
Contributor

Saklad5 commented Nov 2, 2016

@vitorgalvao
Copy link
Member

@Saklad5 Thank you. I actually went to the page but jumped that section, for some reason.

@miccal miccal removed the meta label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants