Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_pds_up hard-codes the /discovery/ping url. #22

Open
bradmontgomery opened this issue Oct 31, 2014 · 2 comments
Open

is_pds_up hard-codes the /discovery/ping url. #22

bradmontgomery opened this issue Oct 31, 2014 · 2 comments

Comments

@bradmontgomery
Copy link
Contributor

In apps.base.views.is_pds_up, there's a hard-coded value for a discovery url in the PDS, which unfortunately doesn't have that url defined.

Since these are two separate projects, should this be a setting instead of a hard-coded value?

@RogerTangos
Copy link

@brian717 ? The registry server is much more your turf than mine.

@brian717
Copy link
Member

Brad, since you went ahead and re-added that URL on the PDS, the page exists again (its removal was an oversight when the large refactor happened a few weeks ago... sorry about that). I'd say the /discovery/ping url can be part of the openPDS spec, and thus, doesn't need to be configurable - any implementation of openPDS will just be required to have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants