PetabImporter.create_edatas creates incomplete edata objects.

[FFroehlich]

This function appears pretty useless on it's own as fixed parameters etc from the condition table are not filled in. Would expect that the generated objects have partial information that is set by amici.petab.conditions.fill_in_parameters.

[dweindl]

I think that was intentional, but the intention is not sufficiently-well documented.
Nevertheless, I agree that it's probably less surprising if the parameters already get set in there, even if they will have to be updated for the next objective call.

So, I'd be fine with directly calling fill_in_parameters from within create_edatas.

[dweindl]

On second thought, I don't think this function should be used directly by users and rather should be private. What would be your use case?

We could indeed fill in that partial information that is independent of the objective function parameters, but would it be that useful? Before running any simulations, one would still have to call fill_in_parameters with meaningful objective parameters.

That being said, the call to amici.petab.conditions.create_edatas in pypesto.petab.objective_creator.AmiciObjectiveCreator.create_edatas could just be replaced by amici.petab.conditions.create_parameterized_edatas and some parameter vector (all-NaN? petab nominalValue? ...?).